fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-25 13:00:16 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

dns: add fixme comment to not block while writing to resolvconf/netconfig

Browse source 
Arguably, a fixme comment isn't useful. It would be better to fix it.
On the other hand, nowadays these modes are not very popular and usually
not used. If somebody cares, please provide a patch.
This commit is contained in:
Thomas Haller 2020-08-08 10:24:40 +02:00
parent 935e9a4f92
commit c752c52b76
No known key found for this signature in database
GPG key ID: 29C2366E4DFC5728
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/dns/nm-dns-manager.c
View file

@ -574,6 +574,8 @@ again:
nm_close (fd);
/* FIXME: don't write to netconfig synchronously. */
/* Wait until the process exits */
if (!nm_utils_kill_child_sync (pid, 0, LOGD_DNS, "netconfig", &status, 1000, 0)) {
errsv = errno;
@ -751,6 +753,8 @@ dispatch_resolvconf (NMDnsManager *self,
_LOGI ("Writing DNS information to %s", RESOLVCONF_PATH);
/* FIXME: don't write to resolvconf synchronously. */
cmd = g_strconcat (RESOLVCONF_PATH, " -a ", "NetworkManager", NULL);
if ((f = popen (cmd, "w")) == NULL) {
errsv = errno;