From c47b0201affd382c45df84db642b86fe3ad87e79 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Tue, 26 Jul 2022 17:20:00 +0200 Subject: [PATCH] fix: dont return NM_DEVICE_CAP_IS_SOFTWARE for loopback You cannot create or delete loopback devices. They are always there. Sure, they are purely in software, but still. If we return that loopback has NM_DEVICE_CAP_IS_SOFTWARE, there are probably other places that needs to be fixed, where we need to special case loopback for this reason. It might be easier to just claim that loopback is not a software device. --- src/core/devices/nm-device-loopback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/devices/nm-device-loopback.c b/src/core/devices/nm-device-loopback.c index 269c772a4f..a5cfd56ca3 100644 --- a/src/core/devices/nm-device-loopback.c +++ b/src/core/devices/nm-device-loopback.c @@ -38,7 +38,7 @@ G_DEFINE_TYPE(NMDeviceLoopback, nm_device_loopback, NM_TYPE_DEVICE) static NMDeviceCapabilities get_generic_capabilities(NMDevice *dev) { - return NM_DEVICE_CAP_IS_SOFTWARE; + return NM_DEVICE_CAP_NONE; } static guint32