From c4758ef30edad2e021b449357bd944ccfb797910 Mon Sep 17 00:00:00 2001 From: Dan Williams Date: Mon, 16 Jan 2012 10:26:01 -0600 Subject: [PATCH] core: let callers do error logging for nm_netlink_route_add() Callers of this function have a better idea of they want to log errors or not. Let them handle it, since they already do, and having a warning here was causing duplicate log messages. --- src/nm-netlink-utils.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/nm-netlink-utils.c b/src/nm-netlink-utils.c index 4a62aa551f..c8adc9609b 100644 --- a/src/nm-netlink-utils.c +++ b/src/nm-netlink-utils.c @@ -170,7 +170,7 @@ nm_netlink_route_new (int ifindex, * * Returns: zero if succeeded or the netlink error otherwise. **/ -int nm_netlink_route_add(struct rtnl_route * route, +int nm_netlink_route_add (struct rtnl_route * route, int family, const void * dest, /* in_addr or in6_addr */ int dest_prefix, @@ -236,11 +236,6 @@ int nm_netlink_route_add(struct rtnl_route * route, if (err == -NLE_FAILURE) err = -NLE_OBJ_NOTFOUND; - if (err) - nm_log_warn (LOGD_DEVICE | log, - "Failed to add route %s", - nl_geterror(err)); - return err; }