From c411b8900f37dc2da883da1ffd3cf46f1d996e41 Mon Sep 17 00:00:00 2001 From: Lubomir Rintel Date: Tue, 5 Mar 2019 19:59:06 +0100 Subject: [PATCH] platform/linux: fix detection of IFA_FLAGS support The condition got accidentally reversed, which means we're always undecided and thus wrongly assuming support and never being able to set any addresses. This would bother the few that are struck with 3.4 android kernels. Very few indeed, given this got unnoticed since 1.10. Fixes: 8670aacc7cee ('platform: cleanup detecting kernel support for IFA_FLAGS and IPv6LL') (cherry picked from commit d551a0893e4b17cfacf9dad70b1b7584d3d68762) --- src/platform/nm-linux-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/platform/nm-linux-platform.c b/src/platform/nm-linux-platform.c index f6b04833d9..4bf8555802 100644 --- a/src/platform/nm-linux-platform.c +++ b/src/platform/nm-linux-platform.c @@ -590,7 +590,7 @@ _support_kernel_extended_ifa_flags_detect (struct nl_msg *msg) /* IFA_FLAGS is set for IPv4 and IPv6 addresses. It was added first to IPv6, * but if we encounter an IPv4 address with IFA_FLAGS, we surely have support. */ - if (NM_IN_SET (((struct ifaddrmsg *) nlmsg_data (msg_hdr))->ifa_family, AF_INET, AF_INET6)) + if (!NM_IN_SET (((struct ifaddrmsg *) nlmsg_data (msg_hdr))->ifa_family, AF_INET, AF_INET6)) return; /* see if the nl_msg contains the IFA_FLAGS attribute. If it does,