fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-30 19:00:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

ifcfg-rh: avoid unnecessary string copies in add_one_wep_key()

Browse source
This commit is contained in:
Thomas Haller 2017-12-04 11:49:03 +01:00 • committed by Beniamino Galvani
parent 5a857b3922
commit c3d192b6a3
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c
View file

@ -2336,22 +2336,23 @@ add_one_wep_key (shvarFile *ifcfg,
NMSettingWirelessSecurity *s_wsec,
GError **error)
{
gs_free char *key = NULL;
gs_free char *value = NULL;
gs_free char *value_free = NULL;
const char *value;
const char *key = NULL;
g_return_val_if_fail (ifcfg != NULL, FALSE);
g_return_val_if_fail (shvar_key != NULL, FALSE);
g_return_val_if_fail (key_idx <= 3, FALSE);
g_return_val_if_fail (s_wsec != NULL, FALSE);
value = svGetValueStr_cp (ifcfg, shvar_key);
value = svGetValueStr (ifcfg, shvar_key, &value_free);
if (!value)
return TRUE;
/* Validate keys */
if (passphrase) {
if (value[0] && strlen (value) < 64)
key = g_strdup (value);
key = value;
} else {
if (NM_IN_SET (strlen (value), 10, 26)) {
/* Hexadecimal WEP key */
@ -2360,7 +2361,7 @@ add_one_wep_key (shvarFile *ifcfg,
"Invalid hexadecimal WEP key.");
return FALSE;
}
key = g_strdup (value);
key = value;
} else if ( !strncmp (value, "s:", 2)
&& NM_IN_SET (strlen (value), 7, 15)) {
/* ASCII key */
@ -2376,7 +2377,7 @@ add_one_wep_key (shvarFile *ifcfg,
* before passing to wpa_supplicant, this prevents two unnecessary conversions. And mainly,
* ASCII WEP key doesn't change to HEX WEP key in UI, which could confuse users.
*/
key = g_strdup (value + 2);
key = value + 2;
}
}
@ -2387,7 +2388,6 @@ add_one_wep_key (shvarFile *ifcfg,
}
nm_setting_wireless_security_set_wep_key (s_wsec, key_idx, key);
return TRUE;
}