From c35d63ddeaa78376254c21b742ce412ce28a5c15 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 26 Jun 2014 17:49:27 +0200 Subject: [PATCH] settings: fix invalid signature in impl_settings_get_connection_by_uuid() impl_settings_get_connection_by_uuid() was changed from a synchronous function to an asynchronous one. Thereby the @out_object_path argument was forgotten, leaving the function completely broken. This bug has the potential to crash NetworkManager. Regression introduced by commit 8ab8990938b995a8b49e995ff844fa359c9b4443. Found running $ ./dfuzzer -v -n com.redhat.ifcfgrh1 Related: https://bugzilla.redhat.com/show_bug.cgi?id=1113508 Signed-off-by: Thomas Haller --- src/settings/nm-settings.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/settings/nm-settings.c b/src/settings/nm-settings.c index d3054eb251..6783c130f8 100644 --- a/src/settings/nm-settings.c +++ b/src/settings/nm-settings.c @@ -93,7 +93,6 @@ static gboolean impl_settings_list_connections (NMSettings *self, static void impl_settings_get_connection_by_uuid (NMSettings *self, const char *uuid, - char **out_object_path, DBusGMethodInvocation *context); static void impl_settings_add_connection (NMSettings *self, @@ -272,7 +271,6 @@ nm_settings_get_connection_by_uuid (NMSettings *self, const char *uuid) static void impl_settings_get_connection_by_uuid (NMSettings *self, const char *uuid, - char **out_object_path, DBusGMethodInvocation *context) { NMSettingsConnection *connection = NULL;