fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-29 02:10:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

ifcfg-rh: let reader create lineList in O(n) using g_list_prepend() and g_list_reverse()

Browse source
This commit is contained in:
Thomas Haller 2016-11-01 15:53:04 +01:00
parent eb307bbbb6
commit c20b795547
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/settings/plugins/ifcfg-rh/shvar.c
View file

@ -629,10 +629,11 @@ svOpenFileInternal (const char *name, gboolean create, GError **error)
/* we'd use g_strsplit() here, but we want a list, not an array */
for (p = arena; (q = strchr (p, '\n')) != NULL; p = q + 1)
s->lineList = g_list_append (s->lineList, g_strndup (p, q - p));
s->lineList = g_list_prepend (s->lineList, g_strndup (p, q - p));
if (p[0])
s->lineList = g_list_append (s->lineList, g_strdup (p));
s->lineList = g_list_prepend (s->lineList, g_strdup (p));
g_free (arena);
s->lineList = g_list_reverse (s->lineList);
/* closefd is set if we opened the file read-only, so go ahead and
* close it, because we can't write to it anyway