From c0ecd2f62815606824bc934599dc46b069fe9962 Mon Sep 17 00:00:00 2001 From: Dan Winship Date: Fri, 12 Sep 2014 16:18:41 -0400 Subject: [PATCH] tui: fix a crash NMSettingIP4Config:dns is NULL if no DNS servers are set --- clients/tui/nm-editor-bindings.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/clients/tui/nm-editor-bindings.c b/clients/tui/nm-editor-bindings.c index e3b210dec6..1b0bd4a6cc 100644 --- a/clients/tui/nm-editor-bindings.c +++ b/clients/tui/nm-editor-bindings.c @@ -230,9 +230,11 @@ ip4_addresses_check_and_copy (GBinding *binding, strings = g_value_get_boxed (source_value); - for (i = 0; strings[i]; i++) { - if (!ip_string_parse (strings[i], AF_INET, &addr, NULL)) - return FALSE; + if (strings) { + for (i = 0; strings[i]; i++) { + if (!ip_string_parse (strings[i], AF_INET, &addr, NULL)) + return FALSE; + } } g_value_set_boxed (target_value, strings); @@ -690,9 +692,11 @@ ip6_addresses_check_and_copy (GBinding *binding, strings = g_value_get_boxed (source_value); - for (i = 0; strings[i]; i++) { - if (!ip_string_parse (strings[i], AF_INET6, &addr, NULL)) - return FALSE; + if (strings) { + for (i = 0; strings[i]; i++) { + if (!ip_string_parse (strings[i], AF_INET6, &addr, NULL)) + return FALSE; + } } g_value_set_boxed (target_value, strings);