bpf: clat: change the signature of update_icmp_checksum()

- rename argument 'add' to 'v4to6'
- make argument 'ip6h' const since it's not modified by the function
This commit is contained in:
Beniamino Galvani 2025-10-28 21:57:02 +01:00
parent 6a1f5a764e
commit c0d5e9ab91

View file

@ -112,10 +112,10 @@ update_l4_checksum(struct __sk_buff *skb,
static void static void
update_icmp_checksum(struct __sk_buff *skb, update_icmp_checksum(struct __sk_buff *skb,
struct ipv6hdr *ip6h, const struct ipv6hdr *ip6h,
void *icmp_before, void *icmp_before,
void *icmp_after, void *icmp_after,
bool add) bool v4to6)
{ {
struct icmpv6_pseudo ph = {.nh = IPPROTO_ICMPV6, .len = ip6h->payload_len}; struct icmpv6_pseudo ph = {.nh = IPPROTO_ICMPV6, .len = ip6h->payload_len};
__u16 h_before, h_after; __u16 h_before, h_after;
@ -136,12 +136,12 @@ update_icmp_checksum(struct __sk_buff *skb,
* itself. * itself.
*/ */
csum = bpf_csum_diff((__be32 *) &ph, csum = bpf_csum_diff((__be32 *) &ph,
add ? 0 : sizeof(ph), v4to6 ? 0 : sizeof(ph),
(__be32 *) &ph, (__be32 *) &ph,
add ? sizeof(ph) : 0, v4to6 ? sizeof(ph) : 0,
0); 0);
offset = sizeof(struct ethhdr) + (add ? sizeof(struct iphdr) : sizeof(struct ipv6hdr)) + 2; offset = sizeof(struct ethhdr) + (v4to6 ? sizeof(struct iphdr) : sizeof(struct ipv6hdr)) + 2;
/* first two bytes of ICMP header, type and code */ /* first two bytes of ICMP header, type and code */
h_before = *(__u16 *) icmp_before; h_before = *(__u16 *) icmp_before;