From bcb1ab9e1c54410f4048a46183bf1d0fca7e703d Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Mon, 21 Mar 2022 18:51:26 +0100 Subject: [PATCH] libnm/802-1x: don't use g_warning() in need_secrets_tls() g_warning() for unexpected scheme is not right. Either, this should be an assertion (and never be hit), or the library should be silent about conditions that can happen regularly. --- src/libnm-core-impl/nm-setting-8021x.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/libnm-core-impl/nm-setting-8021x.c b/src/libnm-core-impl/nm-setting-8021x.c index a9d430873e..de5c3a48ff 100644 --- a/src/libnm-core-impl/nm-setting-8021x.c +++ b/src/libnm-core-impl/nm-setting-8021x.c @@ -2565,8 +2565,6 @@ need_secrets_tls(NMSetting8021x *self, GPtrArray *secrets, gboolean phase2) else if (scheme == NM_SETTING_802_1X_CK_SCHEME_BLOB) blob = phase2 ? nm_setting_802_1x_get_phase2_private_key_blob(self) : nm_setting_802_1x_get_private_key_blob(self); - else if (scheme != NM_SETTING_802_1X_CK_SCHEME_PKCS11) - g_warning("%s: unknown %sprivate key scheme %d", __func__, phase2 ? "phase2 " : "", scheme); if (need_private_key_password( blob, scheme,