fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-31 11:20:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

dhcp: merge branch 'bg/dhcp-reject-servers'

Browse source 
https://bugzilla.redhat.com/show_bug.cgi?id=1827410
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/581
This commit is contained in:
Beniamino Galvani 2020-08-26 17:30:45 +02:00
commit bc4c81fb43
29 changed files with 1082 additions and 570 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
clients/common/nm-meta-setting-desc.c
View file

@ -2151,6 +2151,19 @@ _multilist_validate_fcn_is_domain (const char *domain, GError **error)
return domain;
}
static const char *
_multilist_validate_fcn_is_ipv4_addr_or_subnet (const char *value, GError **error)
{
if (!nm_utils_parse_inaddr_prefix_bin (AF_INET, value, NULL, NULL, NULL)) {
nm_utils_error_set (error, NM_UTILS_ERROR_INVALID_ARGUMENT,
_("invalid IPv4 or subnet \"%s\""),
value);
return NULL;
}
return value;
}
static gboolean
_set_fcn_gobject_bytes (ARGS_SET_FCN)
{
@ -3445,6 +3458,31 @@ _objlist_set_fcn_ip_config_routing_rules (NMSetting *setting,
return TRUE;
}
static guint
_multilist_get_num_fcn_ip_config_dhcp_reject_servers (NMSettingIPConfig *setting)
{
guint num;
nm_setting_ip_config_get_dhcp_reject_servers (setting, &num);
return num;
}
static gboolean
_multilist_remove_by_value_fcn_ip_config_dhcp_reject_servers (NMSettingIPConfig *setting,
const char *item)
{
const char *const *strv;
guint num;
gssize idx;
strv = nm_setting_ip_config_get_dhcp_reject_servers (setting, &num);
idx = nm_utils_strv_find_first ((char **) strv, num, item);
if (idx >= 0)
nm_setting_ip_config_remove_dhcp_reject_server (setting, idx);
return TRUE;
}
static gconstpointer
_get_fcn_olpc_mesh_ssid (ARGS_GET_FCN)
{
@ -5837,6 +5875,19 @@ static const NMMetaPropertyInfo *const property_infos_IP4_CONFIG[] = {
PROPERTY_INFO_WITH_DESC (NM_SETTING_IP4_CONFIG_DHCP_VENDOR_CLASS_IDENTIFIER,
.property_type = &_pt_gobject_string,
),
PROPERTY_INFO (NM_SETTING_IP_CONFIG_DHCP_REJECT_SERVERS, DESCRIBE_DOC_NM_SETTING_IP4_CONFIG_DHCP_REJECT_SERVERS,
.property_type = &_pt_multilist,
.property_typ_data = DEFINE_PROPERTY_TYP_DATA (
PROPERTY_TYP_DATA_SUBTYPE (multilist,
.get_num_fcn_u = MULTILIST_GET_NUM_FCN_U (NMSettingIPConfig, _multilist_get_num_fcn_ip_config_dhcp_reject_servers),
.add2_fcn = MULTILIST_ADD2_FCN (NMSettingIPConfig, nm_setting_ip_config_add_dhcp_reject_server),
.remove_by_idx_fcn_u = MULTILIST_REMOVE_BY_IDX_FCN_U (NMSettingIPConfig, nm_setting_ip_config_remove_dhcp_reject_server),
.remove_by_value_fcn = MULTILIST_REMOVE_BY_VALUE_FCN (NMSettingIPConfig, _multilist_remove_by_value_fcn_ip_config_dhcp_reject_servers),
.validate_fcn = _multilist_validate_fcn_is_ipv4_addr_or_subnet,
.strsplit_plain = TRUE,
),
),
),
NULL
};

2
clients/common/settings-docs.h.in
View file

@ -228,6 +228,7 @@
#define DESCRIBE_DOC_NM_SETTING_IP4_CONFIG_DHCP_HOSTNAME N_("If the \"dhcp-send-hostname\" property is TRUE, then the specified name will be sent to the DHCP server when acquiring a lease. This property and \"dhcp-fqdn\" are mutually exclusive and cannot be set at the same time.")
#define DESCRIBE_DOC_NM_SETTING_IP4_CONFIG_DHCP_HOSTNAME_FLAGS N_("Flags for the DHCP hostname and FQDN. Currently, this property only includes flags to control the FQDN flags set in the DHCP FQDN option. Supported FQDN flags are NM_DHCP_HOSTNAME_FLAG_FQDN_SERV_UPDATE (0x1), NM_DHCP_HOSTNAME_FLAG_FQDN_ENCODED (0x2) and NM_DHCP_HOSTNAME_FLAG_FQDN_NO_UPDATE (0x4). When no FQDN flag is set and NM_DHCP_HOSTNAME_FLAG_FQDN_CLEAR_FLAGS (0x8) is set, the DHCP FQDN option will contain no flag. Otherwise, if no FQDN flag is set and NM_DHCP_HOSTNAME_FLAG_FQDN_CLEAR_FLAGS (0x8) is not set, the standard FQDN flags are set in the request: NM_DHCP_HOSTNAME_FLAG_FQDN_SERV_UPDATE (0x1), NM_DHCP_HOSTNAME_FLAG_FQDN_ENCODED (0x2) for IPv4 and NM_DHCP_HOSTNAME_FLAG_FQDN_SERV_UPDATE (0x1) for IPv6. When this property is set to the default value NM_DHCP_HOSTNAME_FLAG_NONE (0x0), a global default is looked up in NetworkManager configuration. If that value is unset or also NM_DHCP_HOSTNAME_FLAG_NONE (0x0), then the standard FQDN flags described above are sent in the DHCP requests.")
#define DESCRIBE_DOC_NM_SETTING_IP4_CONFIG_DHCP_IAID N_("A string containing the \"Identity Association Identifier\" (IAID) used by the DHCP client. The property is a 32-bit decimal value or a special value among \"mac\", \"perm-mac\", \"ifname\" and \"stable\". When set to \"mac\" (or \"perm-mac\"), the last 4 bytes of the current (or permanent) MAC address are used as IAID. When set to \"ifname\", the IAID is computed by hashing the interface name. The special value \"stable\" can be used to generate an IAID based on the stable-id (see connection.stable-id), a per-host key and the interface name. When the property is unset, the value from global configuration is used; if no global default is set then the IAID is assumed to be \"ifname\". Note that at the moment this property is ignored for IPv6 by dhclient, which always derives the IAID from the MAC address.")
#define DESCRIBE_DOC_NM_SETTING_IP4_CONFIG_DHCP_REJECT_SERVERS N_("Array of servers from which DHCP offers must be rejected. This property is useful to avoid getting a lease from misconfigured or rogue servers. For DHCPv4, each element must be an IPv4 address, optionally followed by a slash and a prefix length (e.g. \"192.168.122.0/24\"). This property is currently not implemented for DHCPv6.")
#define DESCRIBE_DOC_NM_SETTING_IP4_CONFIG_DHCP_SEND_HOSTNAME N_("If TRUE, a hostname is sent to the DHCP server when acquiring a lease. Some DHCP servers use this hostname to update DNS databases, essentially providing a static hostname for the computer. If the \"dhcp-hostname\" property is NULL and this property is TRUE, the current persistent hostname of the computer is sent.")
#define DESCRIBE_DOC_NM_SETTING_IP4_CONFIG_DHCP_TIMEOUT N_("A timeout for a DHCP transaction in seconds. If zero (the default), a globally configured default is used. If still unspecified, a device specific timeout is used (usually 45 seconds). Set to 2147483647 (MAXINT32) for infinity.")
#define DESCRIBE_DOC_NM_SETTING_IP4_CONFIG_DHCP_VENDOR_CLASS_IDENTIFIER N_("The Vendor Class Identifier DHCP option (60). Special characters in the data string may be escaped using C-style escapes, nevertheless this property cannot contain nul bytes. If the per-profile value is unspecified (the default), a global connection default gets consulted. If still unspecified, the DHCP option is not sent to the server. Since 1.28")
@ -251,6 +252,7 @@
#define DESCRIBE_DOC_NM_SETTING_IP6_CONFIG_DHCP_HOSTNAME N_("If the \"dhcp-send-hostname\" property is TRUE, then the specified name will be sent to the DHCP server when acquiring a lease. This property and \"dhcp-fqdn\" are mutually exclusive and cannot be set at the same time.")
#define DESCRIBE_DOC_NM_SETTING_IP6_CONFIG_DHCP_HOSTNAME_FLAGS N_("Flags for the DHCP hostname and FQDN. Currently, this property only includes flags to control the FQDN flags set in the DHCP FQDN option. Supported FQDN flags are NM_DHCP_HOSTNAME_FLAG_FQDN_SERV_UPDATE (0x1), NM_DHCP_HOSTNAME_FLAG_FQDN_ENCODED (0x2) and NM_DHCP_HOSTNAME_FLAG_FQDN_NO_UPDATE (0x4). When no FQDN flag is set and NM_DHCP_HOSTNAME_FLAG_FQDN_CLEAR_FLAGS (0x8) is set, the DHCP FQDN option will contain no flag. Otherwise, if no FQDN flag is set and NM_DHCP_HOSTNAME_FLAG_FQDN_CLEAR_FLAGS (0x8) is not set, the standard FQDN flags are set in the request: NM_DHCP_HOSTNAME_FLAG_FQDN_SERV_UPDATE (0x1), NM_DHCP_HOSTNAME_FLAG_FQDN_ENCODED (0x2) for IPv4 and NM_DHCP_HOSTNAME_FLAG_FQDN_SERV_UPDATE (0x1) for IPv6. When this property is set to the default value NM_DHCP_HOSTNAME_FLAG_NONE (0x0), a global default is looked up in NetworkManager configuration. If that value is unset or also NM_DHCP_HOSTNAME_FLAG_NONE (0x0), then the standard FQDN flags described above are sent in the DHCP requests.")
#define DESCRIBE_DOC_NM_SETTING_IP6_CONFIG_DHCP_IAID N_("A string containing the \"Identity Association Identifier\" (IAID) used by the DHCP client. The property is a 32-bit decimal value or a special value among \"mac\", \"perm-mac\", \"ifname\" and \"stable\". When set to \"mac\" (or \"perm-mac\"), the last 4 bytes of the current (or permanent) MAC address are used as IAID. When set to \"ifname\", the IAID is computed by hashing the interface name. The special value \"stable\" can be used to generate an IAID based on the stable-id (see connection.stable-id), a per-host key and the interface name. When the property is unset, the value from global configuration is used; if no global default is set then the IAID is assumed to be \"ifname\". Note that at the moment this property is ignored for IPv6 by dhclient, which always derives the IAID from the MAC address.")
#define DESCRIBE_DOC_NM_SETTING_IP6_CONFIG_DHCP_REJECT_SERVERS N_("Array of servers from which DHCP offers must be rejected. This property is useful to avoid getting a lease from misconfigured or rogue servers. For DHCPv4, each element must be an IPv4 address, optionally followed by a slash and a prefix length (e.g. \"192.168.122.0/24\"). This property is currently not implemented for DHCPv6.")
#define DESCRIBE_DOC_NM_SETTING_IP6_CONFIG_DHCP_SEND_HOSTNAME N_("If TRUE, a hostname is sent to the DHCP server when acquiring a lease. Some DHCP servers use this hostname to update DNS databases, essentially providing a static hostname for the computer. If the \"dhcp-hostname\" property is NULL and this property is TRUE, the current persistent hostname of the computer is sent.")
#define DESCRIBE_DOC_NM_SETTING_IP6_CONFIG_DHCP_TIMEOUT N_("A timeout for a DHCP transaction in seconds. If zero (the default), a globally configured default is used. If still unspecified, a device specific timeout is used (usually 45 seconds). Set to 2147483647 (MAXINT32) for infinity.")
#define DESCRIBE_DOC_NM_SETTING_IP6_CONFIG_DNS N_("Array of IP addresses of DNS servers.")

482
clients/tests/test-client.check-on-disk/test_003.expected
View file

File diff suppressed because it is too large Load diff

678
clients/tests/test-client.check-on-disk/test_004.expected
View file

File diff suppressed because it is too large Load diff

146
libnm-core/nm-setting-ip-config.c
View file

@ -3633,6 +3633,7 @@ NM_GOBJECT_PROPERTIES_DEFINE (NMSettingIPConfig,
PROP_DAD_TIMEOUT,
PROP_DHCP_TIMEOUT,
PROP_DHCP_IAID,
PROP_DHCP_REJECT_SERVERS,
);
typedef struct {
@ -3642,6 +3643,7 @@ typedef struct {
GPtrArray *addresses; /* array of NMIPAddress */
GPtrArray *routes; /* array of NMIPRoute */
GPtrArray *routing_rules;
GArray *dhcp_reject_servers;
char *method;
char *gateway;
char *dhcp_hostname;
@ -4949,6 +4951,92 @@ nm_setting_ip_config_get_dhcp_iaid (NMSettingIPConfig *setting)
return NM_SETTING_IP_CONFIG_GET_PRIVATE (setting)->dhcp_iaid;
}
/**
* nm_setting_ip_config_get_dhcp_reject_servers:
* @setting: the #NMSettingIPConfig
* @out_len: (allow-none) (out): the number of returned elements
*
* Returns: (array length=out_len zero-terminated=1) (transfer none):
* A %NULL terminated array of DHCP reject servers. Even if no reject
* servers are configured, this always returns a non %NULL value.
*
* Since: 1.28
*/
const char *const *
nm_setting_ip_config_get_dhcp_reject_servers (NMSettingIPConfig *setting, guint *out_len)
{
g_return_val_if_fail (NM_IS_SETTING_IP_CONFIG (setting), NULL);
return nm_strvarray_get_strv (&NM_SETTING_IP_CONFIG_GET_PRIVATE (setting)->dhcp_reject_servers,
out_len);
}
/**
* nm_setting_ip_config_add_dhcp_reject_server:
* @setting: the #NMSettingIPConfig
* @server: the DHCP reject server to add
*
* Adds a new DHCP reject server to the setting.
*
* Since: 1.28
**/
void
nm_setting_ip_config_add_dhcp_reject_server (NMSettingIPConfig *setting,
const char *server)
{
NMSettingIPConfigPrivate *priv;
g_return_if_fail (NM_IS_SETTING_IP_CONFIG (setting));
g_return_if_fail (server != NULL);
priv = NM_SETTING_IP_CONFIG_GET_PRIVATE (setting);
nm_strvarray_add (nm_strvarray_ensure (&priv->dhcp_reject_servers), server);
_notify (setting, PROP_DHCP_REJECT_SERVERS);
}
/**
* nm_setting_ip_config_remove_dhcp_reject_server:
* @setting: the #NMSettingIPConfig
* @idx: index number of the DHCP reject server
*
* Removes the DHCP reject server at index @idx.
*
* Since: 1.28
**/
void
nm_setting_ip_config_remove_dhcp_reject_server (NMSettingIPConfig *setting, guint idx)
{
NMSettingIPConfigPrivate *priv;
g_return_if_fail (NM_IS_SETTING_IP_CONFIG (setting));
priv = NM_SETTING_IP_CONFIG_GET_PRIVATE (setting);
g_return_if_fail (priv->dhcp_reject_servers && idx < priv->dhcp_reject_servers->len);
g_array_remove_index (priv->dhcp_reject_servers, idx);
_notify (setting, PROP_DHCP_REJECT_SERVERS);
}
/**
* nm_setting_ip_config_clear_dhcp_reject_servers:
* @setting: the #NMSettingIPConfig
*
* Removes all configured DHCP reject servers.
*
* Since: 1.28
**/
void
nm_setting_ip_config_clear_dhcp_reject_servers (NMSettingIPConfig *setting)
{
NMSettingIPConfigPrivate *priv;
g_return_if_fail (NM_IS_SETTING_IP_CONFIG (setting));
priv = NM_SETTING_IP_CONFIG_GET_PRIVATE (setting);
if (nm_g_array_len (priv->dhcp_reject_servers) != 0) {
nm_clear_pointer (&priv->dhcp_reject_servers, g_array_unref);
_notify (setting, PROP_DHCP_REJECT_SERVERS);
}
}
static gboolean
verify_label (const char *label)
{
@ -5159,6 +5247,38 @@ verify (NMSetting *setting, NMConnection *connection, GError **error)
return FALSE;
}
/* Validate reject servers */
if ( priv->dhcp_reject_servers
&& priv->dhcp_reject_servers->len != 0) {
if (NM_SETTING_IP_CONFIG_GET_FAMILY (setting) != AF_INET) {
g_set_error_literal (error,
NM_CONNECTION_ERROR,
NM_CONNECTION_ERROR_INVALID_PROPERTY,
_("the property is currently supported only for DHCPv4"));
g_prefix_error (error, "%s.%s: ",
nm_setting_get_name (setting),
NM_SETTING_IP_CONFIG_DHCP_REJECT_SERVERS);
return FALSE;
}
for (i = 0; i < priv->dhcp_reject_servers->len; i++) {
if (!nm_utils_parse_inaddr_prefix (NM_SETTING_IP_CONFIG_GET_FAMILY (setting),
g_array_index (priv->dhcp_reject_servers, const char *, i),
NULL,
NULL)) {
g_set_error (error,
NM_CONNECTION_ERROR,
NM_CONNECTION_ERROR_INVALID_PROPERTY,
_("'%s' is not a valid IP or subnet"),
g_array_index (priv->dhcp_reject_servers, const char *, i));
g_prefix_error (error, "%s.%s: ",
nm_setting_get_name (setting),
NM_SETTING_IP_CONFIG_DHCP_REJECT_SERVERS);
return FALSE;
}
}
}
/* Normalizable errors */
if (priv->gateway && priv->never_default) {
g_set_error (error,
@ -5434,6 +5554,9 @@ get_property (GObject *object, guint prop_id,
case PROP_DHCP_HOSTNAME_FLAGS:
g_value_set_uint (value, nm_setting_ip_config_get_dhcp_hostname_flags (setting));
break;
case PROP_DHCP_REJECT_SERVERS:
g_value_set_boxed (value, nm_strvarray_get_strv_non_empty (priv->dhcp_reject_servers, NULL));
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
break;
@ -5540,6 +5663,9 @@ set_property (GObject *object, guint prop_id,
case PROP_DHCP_HOSTNAME_FLAGS:
priv->dhcp_hostname_flags = g_value_get_uint (value);
break;
case PROP_DHCP_REJECT_SERVERS:
nm_strvarray_set_strv (&priv->dhcp_reject_servers, g_value_get_boxed (value));
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
break;
@ -5582,6 +5708,7 @@ finalize (GObject *object)
g_ptr_array_unref (priv->routes);
if (priv->routing_rules)
g_ptr_array_unref (priv->routing_rules);
nm_clear_pointer (&priv->dhcp_reject_servers, g_array_unref);
G_OBJECT_CLASS (nm_setting_ip_config_parent_class)->finalize (object);
}
@ -6004,5 +6131,24 @@ nm_setting_ip_config_class_init (NMSettingIPConfigClass *klass)
G_PARAM_READWRITE |
G_PARAM_STATIC_STRINGS);
/**
* NMSettingIPConfig:dhcp-reject-servers:
*
* Array of servers from which DHCP offers must be rejected. This property
* is useful to avoid getting a lease from misconfigured or rogue servers.
*
* For DHCPv4, each element must be an IPv4 address, optionally
* followed by a slash and a prefix length (e.g. "192.168.122.0/24").
*
* This property is currently not implemented for DHCPv6.
*
* Since: 1.28
**/
obj_properties[PROP_DHCP_REJECT_SERVERS] =
g_param_spec_boxed (NM_SETTING_IP_CONFIG_DHCP_REJECT_SERVERS, "", "",
G_TYPE_STRV,
G_PARAM_READWRITE |
G_PARAM_STATIC_STRINGS);
g_object_class_install_properties (object_class, _PROPERTY_ENUMS_LAST, obj_properties);
}

14
libnm-core/nm-setting-ip-config.h
View file

@ -350,6 +350,7 @@ char *nm_ip_routing_rule_to_string (const NMIPRoutingRule *self,
#define NM_SETTING_IP_CONFIG_DAD_TIMEOUT "dad-timeout"
#define NM_SETTING_IP_CONFIG_DHCP_TIMEOUT "dhcp-timeout"
#define NM_SETTING_IP_CONFIG_DHCP_IAID "dhcp-iaid"
#define NM_SETTING_IP_CONFIG_DHCP_REJECT_SERVERS "dhcp-reject-servers"
/* these are not real GObject properties. */
#define NM_SETTING_IP_CONFIG_ROUTING_RULES "routing-rules"
@ -529,6 +530,19 @@ const char *nm_setting_ip_config_get_dhcp_iaid (NMSettingIPConfig
NM_AVAILABLE_IN_1_22
NMDhcpHostnameFlags nm_setting_ip_config_get_dhcp_hostname_flags (NMSettingIPConfig *setting);
NM_AVAILABLE_IN_1_28
const char *const *nm_setting_ip_config_get_dhcp_reject_servers (NMSettingIPConfig *setting,
guint *out_len);
NM_AVAILABLE_IN_1_28
void nm_setting_ip_config_add_dhcp_reject_server (NMSettingIPConfig *setting,
const char *server);
NM_AVAILABLE_IN_1_28
void nm_setting_ip_config_remove_dhcp_reject_server (NMSettingIPConfig *setting,
guint idx);
NM_AVAILABLE_IN_1_28
void nm_setting_ip_config_clear_dhcp_reject_servers (NMSettingIPConfig *setting);
G_END_DECLS
#endif /* NM_SETTING_IP_CONFIG_H */

60
libnm-core/nm-setting-match.c
View file

@ -139,22 +139,15 @@ gboolean
nm_setting_match_remove_interface_name_by_value (NMSettingMatch *setting,
const char *interface_name)
{
guint i;
g_return_val_if_fail (NM_IS_SETTING_MATCH (setting), FALSE);
g_return_val_if_fail (interface_name != NULL, FALSE);
g_return_val_if_fail (interface_name[0] != '\0', FALSE);
if (!setting->interface_name)
return FALSE;
for (i = 0; i < setting->interface_name->len; i++) {
if (nm_streq (interface_name, g_array_index (setting->interface_name, const char *, i))) {
g_array_remove_index (setting->interface_name, i);
_notify (setting, PROP_INTERFACE_NAME);
return TRUE;
}
if (nm_strvarray_remove_first (setting->interface_name, interface_name)) {
_notify (setting, PROP_INTERFACE_NAME);
return TRUE;
}
return FALSE;
}
@ -292,22 +285,15 @@ gboolean
nm_setting_match_remove_kernel_command_line_by_value (NMSettingMatch *setting,
const char *kernel_command_line)
{
guint i;
g_return_val_if_fail (NM_IS_SETTING_MATCH (setting), FALSE);
g_return_val_if_fail (kernel_command_line != NULL, FALSE);
g_return_val_if_fail (kernel_command_line[0] != '\0', FALSE);
if (!setting->kernel_command_line)
return FALSE;
for (i = 0; i < setting->kernel_command_line->len; i++) {
if (nm_streq (kernel_command_line, g_array_index (setting->kernel_command_line, const char *, i))) {
g_array_remove_index (setting->kernel_command_line, i);
_notify (setting, PROP_KERNEL_COMMAND_LINE);
return TRUE;
}
if (nm_strvarray_remove_first (setting->kernel_command_line, kernel_command_line)) {
_notify (setting, PROP_KERNEL_COMMAND_LINE);
return TRUE;
}
return FALSE;
}
@ -442,22 +428,15 @@ gboolean
nm_setting_match_remove_driver_by_value (NMSettingMatch *setting,
const char *driver)
{
guint i;
g_return_val_if_fail (NM_IS_SETTING_MATCH (setting), FALSE);
g_return_val_if_fail (driver != NULL, FALSE);
g_return_val_if_fail (driver[0] != '\0', FALSE);
if (!setting->driver)
return FALSE;
for (i = 0; i < setting->driver->len; i++) {
if (nm_streq (driver, g_array_index (setting->driver, const char *, i))) {
g_array_remove_index (setting->driver, i);
_notify (setting, PROP_DRIVER);
return TRUE;
}
if (nm_strvarray_remove_first (setting->driver, driver)) {
_notify (setting, PROP_DRIVER);
return TRUE;
}
return FALSE;
}
@ -592,22 +571,15 @@ gboolean
nm_setting_match_remove_path_by_value (NMSettingMatch *setting,
const char *path)
{
guint i;
g_return_val_if_fail (NM_IS_SETTING_MATCH (setting), FALSE);
g_return_val_if_fail (path != NULL, FALSE);
g_return_val_if_fail (path[0] != '\0', FALSE);
if (!setting->path)
return FALSE;
for (i = 0; i < setting->path->len; i++) {
if (nm_streq (path, g_array_index (setting->path, const char *, i))) {
g_array_remove_index (setting->path, i);
_notify (setting, PROP_PATH);
return TRUE;
}
if (nm_strvarray_remove_first (setting->path, path)) {
_notify (setting, PROP_PATH);
return TRUE;
}
return FALSE;
}

1
libnm-core/tests/test-general.c
View file

@ -3388,6 +3388,7 @@ test_connection_diff_a_only (void)
{ NM_SETTING_IP_CONFIG_DNS_PRIORITY, NM_SETTING_DIFF_RESULT_IN_A },
{ NM_SETTING_IP_CONFIG_DHCP_IAID, NM_SETTING_DIFF_RESULT_IN_A },
{ NM_SETTING_IP4_CONFIG_DHCP_VENDOR_CLASS_IDENTIFIER, NM_SETTING_DIFF_RESULT_IN_A },
{ NM_SETTING_IP_CONFIG_DHCP_REJECT_SERVERS, NM_SETTING_DIFF_RESULT_IN_A },
{ NULL, NM_SETTING_DIFF_RESULT_UNKNOWN },
} },
};

4
libnm/libnm.ver
View file

@ -1749,5 +1749,9 @@ global:
libnm_1_28_0 {
global:
nm_setting_ip_config_add_dhcp_reject_server;
nm_setting_ip_config_clear_dhcp_reject_servers;
nm_setting_ip_config_get_dhcp_reject_servers;
nm_setting_ip_config_remove_dhcp_reject_server;
nm_setting_wireless_get_ap_isolation;
} libnm_1_26_4;

1
shared/n-dhcp4/src/libndhcp4.sym
View file

@ -36,6 +36,7 @@ global:
n_dhcp4_client_lease_get_yiaddr;
n_dhcp4_client_lease_get_siaddr;
n_dhcp4_client_lease_get_lifetime;
n_dhcp4_client_lease_get_server_identifier;
n_dhcp4_client_lease_query;
n_dhcp4_client_lease_select;
n_dhcp4_client_lease_accept;

26
shared/n-dhcp4/src/n-dhcp4-c-lease.c
View file

@ -241,6 +241,32 @@ _c_public_ void n_dhcp4_client_lease_get_lifetime(NDhcp4ClientLease *lease, uint
*ns_lifetimep = lease->lifetime;
}
/**
* n_dhcp4_client_lease_get_server_identifier() - get the server identifier
* @lease: the lease to operate on
* @addr: return argument for the server identifier
*
* Gets the address contained in the server-identifier DHCP option, in network
* byte order.
*
* Return: 0 on success, negative error code on failure.
*/
_c_public_ int n_dhcp4_client_lease_get_server_identifier (NDhcp4ClientLease *lease, struct in_addr *addr) {
uint8_t *data;
size_t n_data;
int r;
r = n_dhcp4_incoming_query(lease->message, N_DHCP4_OPTION_SERVER_IDENTIFIER, &data, &n_data);
if (r)
return r;
if (n_data < sizeof(struct in_addr))
return N_DHCP4_E_MALFORMED;
memcpy(addr, data, sizeof(struct in_addr));
return 0;
}
/**
* n_dhcp4_client_lease_query() - query the lease for an option
* @lease: the lease to operate on

1
shared/n-dhcp4/src/n-dhcp4.h
View file

@ -171,6 +171,7 @@ void n_dhcp4_client_lease_get_siaddr(NDhcp4ClientLease *lease, struct in_addr *s
void n_dhcp4_client_lease_get_basetime(NDhcp4ClientLease *lease, uint64_t *ns_basetimep);
void n_dhcp4_client_lease_get_lifetime(NDhcp4ClientLease *lease, uint64_t *ns_lifetimep);
int n_dhcp4_client_lease_query(NDhcp4ClientLease *lease, uint8_t option, uint8_t **datap, size_t *n_datap);
int n_dhcp4_client_lease_get_server_identifier (NDhcp4ClientLease *lease, struct in_addr *addr);
int n_dhcp4_client_lease_select(NDhcp4ClientLease *lease);
int n_dhcp4_client_lease_accept(NDhcp4ClientLease *lease);

18
shared/nm-glib-aux/nm-shared-utils.h
View file

@ -2190,6 +2190,24 @@ nm_strvarray_set_strv (GArray **array, const char *const*strv)
nm_strvarray_add (*array, strv[0]);
}
static inline gboolean
nm_strvarray_remove_first (GArray *strv, const char *needle)
{
guint i;
nm_assert (needle);
if (strv) {
for (i = 0; i < strv->len; i++) {
if (nm_streq (needle, g_array_index (strv, const char *, i))) {
g_array_remove_index (strv, i);
return TRUE;
}
}
}
return FALSE;
}
/*****************************************************************************/
struct _NMVariantAttributeSpec {

3
src/devices/nm-device.c
View file

@ -8876,6 +8876,7 @@ dhcp4_start (NMDevice *self)
NMSettingConnection *s_con;
GError *error = NULL;
const NMPlatformLink *pllink;
const char *const *reject_servers;
connection = nm_device_get_applied_connection (self);
g_return_val_if_fail (connection, FALSE);
@ -8898,6 +8899,7 @@ dhcp4_start (NMDevice *self)
client_id = dhcp4_get_client_id (self, connection, hwaddr);
vendor_class_identifier
= dhcp4_get_vendor_class_identifier (self, NM_SETTING_IP4_CONFIG (s_ip4));
reject_servers = nm_setting_ip_config_get_dhcp_reject_servers (s_ip4, NULL);
g_warn_if_fail (priv->dhcp_data_4.client == NULL);
priv->dhcp_data_4.client = nm_dhcp_manager_start_ip4 (nm_dhcp_manager_get (),
@ -8919,6 +8921,7 @@ dhcp4_start (NMDevice *self)
priv->dhcp_anycast_address,
NULL,
vendor_class_identifier,
reject_servers,
&error);
if (!priv->dhcp_data_4.client) {
_LOGW (LOGD_DHCP4, "failure to start DHCP: %s", error->message);

53
src/dhcp/nm-dhcp-client.c
View file

@ -52,6 +52,7 @@ NM_GOBJECT_PROPERTIES_DEFINE (NMDhcpClient,
PROP_HOSTNAME_FLAGS,
PROP_MUD_URL,
PROP_VENDOR_CLASS_IDENTIFIER,
PROP_REJECT_SERVERS,
);
typedef struct _NMDhcpClientPrivate {
@ -62,6 +63,7 @@ typedef struct _NMDhcpClientPrivate {
char * uuid;
GBytes * client_id;
char * hostname;
const char **reject_servers;
char * mud_url;
GBytes * vendor_class_identifier;
pid_t pid;
@ -332,6 +334,14 @@ nm_dhcp_client_get_vendor_class_identifier (NMDhcpClient *self)
return NM_DHCP_CLIENT_GET_PRIVATE (self)->vendor_class_identifier;
}
const char *const *
nm_dhcp_client_get_reject_servers (NMDhcpClient *self)
{
g_return_val_if_fail (NM_IS_DHCP_CLIENT (self), NULL);
return (const char *const *) NM_DHCP_CLIENT_GET_PRIVATE (self)->reject_servers;
}
/*****************************************************************************/
static const char *state_table[NM_DHCP_STATE_MAX + 1] = {
@ -954,6 +964,38 @@ nm_dhcp_client_handle_event (gpointer unused,
return TRUE;
}
gboolean
nm_dhcp_client_server_id_is_rejected (NMDhcpClient *self, gconstpointer addr)
{
NMDhcpClientPrivate *priv = NM_DHCP_CLIENT_GET_PRIVATE (self);
in_addr_t addr4 = *(in_addr_t *) addr;
guint i;
/* IPv6 not implemented yet */
nm_assert (priv->addr_family == AF_INET);
if (!priv->reject_servers || !priv->reject_servers[0])
return FALSE;
for (i = 0; priv->reject_servers[i]; i++) {
in_addr_t r_addr;
in_addr_t mask;
int r_prefix;
if (!nm_utils_parse_inaddr_prefix_bin (AF_INET,
priv->reject_servers[i],
NULL,
&r_addr,
&r_prefix))
nm_assert_not_reached ();
mask = _nm_utils_ip4_prefix_to_netmask (r_prefix < 0 ? 32 : r_prefix);
if ((addr4 & mask) == (r_addr & mask))
return TRUE;
}
return FALSE;
}
/*****************************************************************************/
static void
@ -1090,6 +1132,10 @@ set_property (GObject *object, guint prop_id,
/* construct-only */
priv->vendor_class_identifier = g_value_dup_boxed (value);
break;
case PROP_REJECT_SERVERS:
/* construct-only */
priv->reject_servers = nm_utils_strv_dup_packed (g_value_get_boxed (value), -1);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
break;
@ -1131,6 +1177,7 @@ dispose (GObject *object)
nm_clear_g_free (&priv->hostname);
nm_clear_g_free (&priv->uuid);
nm_clear_g_free (&priv->mud_url);
nm_clear_g_free (&priv->reject_servers);
nm_clear_pointer (&priv->client_id, g_bytes_unref);
nm_clear_pointer (&priv->hwaddr, g_bytes_unref);
nm_clear_pointer (&priv->bcast_hwaddr, g_bytes_unref);
@ -1258,6 +1305,12 @@ nm_dhcp_client_class_init (NMDhcpClientClass *client_class)
G_PARAM_WRITABLE | G_PARAM_CONSTRUCT_ONLY |
G_PARAM_STATIC_STRINGS);
obj_properties[PROP_REJECT_SERVERS] =
g_param_spec_boxed (NM_DHCP_CLIENT_REJECT_SERVERS, "", "",
G_TYPE_STRV,
G_PARAM_WRITABLE | G_PARAM_CONSTRUCT_ONLY |
G_PARAM_STATIC_STRINGS);
g_object_class_install_properties (object_class, _PROPERTY_ENUMS_LAST, obj_properties);
signals[SIGNAL_STATE_CHANGED] =

5
src/dhcp/nm-dhcp-client.h
View file

@ -39,6 +39,7 @@
#define NM_DHCP_CLIENT_IAID_EXPLICIT "iaid-explicit"
#define NM_DHCP_CLIENT_HOSTNAME_FLAGS "hostname-flags"
#define NM_DHCP_CLIENT_VENDOR_CLASS_IDENTIFIER "vendor-class-identifier"
#define NM_DHCP_CLIENT_REJECT_SERVERS "reject-servers"
#define NM_DHCP_CLIENT_SIGNAL_STATE_CHANGED "state-changed"
#define NM_DHCP_CLIENT_SIGNAL_PREFIX_DELEGATED "prefix-delegated"
@ -144,9 +145,11 @@ GBytes *nm_dhcp_client_get_client_id (NMDhcpClient *self);
const char *nm_dhcp_client_get_hostname (NMDhcpClient *self);
const char *nm_dhcp_client_get_mud_url (NMDhcpClient *self);
const char *const *nm_dhcp_client_get_reject_servers (NMDhcpClient *self);
NMDhcpHostnameFlags nm_dhcp_client_get_hostname_flags (NMDhcpClient *self);
gboolean nm_dhcp_client_get_info_only (NMDhcpClient *self);
gboolean nm_dhcp_client_get_use_fqdn (NMDhcpClient *self);
@ -208,6 +211,8 @@ void nm_dhcp_client_set_client_id_bin (NMDhcpClient *self,
void nm_dhcp_client_emit_ipv6_prefix_delegated (NMDhcpClient *self,
const NMPlatformIP6Address *prefix);
gboolean nm_dhcp_client_server_id_is_rejected (NMDhcpClient *self, gconstpointer addr);
/*****************************************************************************
* Client data
*****************************************************************************/

14
src/dhcp/nm-dhcp-dhclient-utils.c
View file

@ -307,6 +307,7 @@ nm_dhcp_dhclient_create_config (const char *interface,
gboolean use_fqdn,
NMDhcpHostnameFlags hostname_flags,
const char *mud_url,
const char *const *reject_servers,
const char *orig_path,
const char *orig_contents,
GBytes **out_new_client_id)
@ -319,6 +320,7 @@ nm_dhcp_dhclient_create_config (const char *interface,
g_return_val_if_fail (!anycast_addr || nm_utils_hwaddr_valid (anycast_addr, ETH_ALEN), NULL);
g_return_val_if_fail (NM_IN_SET (addr_family, AF_INET, AF_INET6), NULL);
g_return_val_if_fail (!reject_servers || addr_family == AF_INET, NULL);
nm_assert (!out_new_client_id || !*out_new_client_id);
new_contents = g_string_new (_("# Created by NetworkManager\n"));
@ -473,6 +475,18 @@ nm_dhcp_dhclient_create_config (const char *interface,
}
add_mud_url_config (new_contents, mud_url, addr_family);
if ( reject_servers
&& reject_servers[0]) {
g_string_append (new_contents, "reject ");
for (i = 0; reject_servers[i]; i++) {
if (i != 0)
g_string_append (new_contents, ", ");
g_string_append (new_contents, reject_servers[i]);
}
g_string_append (new_contents, ";\n");
}
if (addr_family == AF_INET) {
add_ip4_config (new_contents, client_id, hostname, use_fqdn, hostname_flags);
add_request (reqs, "rfc3442-classless-static-routes");

1
src/dhcp/nm-dhcp-dhclient-utils.h
View file

@ -18,6 +18,7 @@ char *nm_dhcp_dhclient_create_config (const char *interface,
gboolean use_fqdn,
NMDhcpHostnameFlags hostname_flags,
const char *mud_url,
const char *const *reject_servers,
const char *orig_path,
const char *orig_contents,
GBytes **out_new_client_id);

6
src/dhcp/nm-dhcp-dhclient.c
View file

@ -148,6 +148,7 @@ merge_dhclient_config (NMDhcpDhclient *self,
gboolean use_fqdn,
NMDhcpHostnameFlags hostname_flags,
const char *mud_url,
const char *const *reject_servers,
const char *orig_path,
GBytes **out_new_client_id,
GError **error)
@ -178,6 +179,7 @@ merge_dhclient_config (NMDhcpDhclient *self,
use_fqdn,
hostname_flags,
mud_url,
reject_servers,
orig_path,
orig,
out_new_client_id);
@ -271,6 +273,7 @@ create_dhclient_config (NMDhcpDhclient *self,
gboolean use_fqdn,
NMDhcpHostnameFlags hostname_flags,
const char *mud_url,
const char *const *reject_servers,
GBytes **out_new_client_id)
{
gs_free char *orig = NULL;
@ -300,6 +303,7 @@ create_dhclient_config (NMDhcpDhclient *self,
use_fqdn,
hostname_flags,
mud_url,
reject_servers,
orig,
out_new_client_id,
&error)) {
@ -501,6 +505,7 @@ ip4_start (NMDhcpClient *client,
nm_dhcp_client_get_use_fqdn (client),
nm_dhcp_client_get_hostname_flags (client),
nm_dhcp_client_get_mud_url (client),
nm_dhcp_client_get_reject_servers (client),
&new_client_id);
if (!priv->conf_file) {
nm_utils_error_set_literal (error,
@ -546,6 +551,7 @@ ip6_start (NMDhcpClient *client,
TRUE,
nm_dhcp_client_get_hostname_flags (client),
nm_dhcp_client_get_mud_url (client),
NULL,
NULL);
if (!priv->conf_file) {
nm_utils_error_set_literal (error,

5
src/dhcp/nm-dhcp-manager.c
View file

@ -226,6 +226,7 @@ client_start (NMDhcpManager *self,
const char *last_ip4_address,
guint needed_prefixes,
GBytes *vendor_class_identifier,
const char *const *reject_servers,
GError **error)
{
NMDhcpManagerPrivate *priv;
@ -318,6 +319,7 @@ client_start (NMDhcpManager *self,
NM_DHCP_CLIENT_TIMEOUT, (guint) timeout,
NM_DHCP_CLIENT_HOSTNAME_FLAGS, (guint) hostname_flags,
NM_DHCP_CLIENT_VENDOR_CLASS_IDENTIFIER, vendor_class_identifier,
NM_DHCP_CLIENT_REJECT_SERVERS, reject_servers,
NM_DHCP_CLIENT_FLAGS, (guint) (0
| (hostname_use_fqdn ? NM_DHCP_CLIENT_FLAGS_USE_FQDN : 0)
| (info_only ? NM_DHCP_CLIENT_FLAGS_INFO_ONLY : 0)
@ -399,6 +401,7 @@ nm_dhcp_manager_start_ip4 (NMDhcpManager *self,
const char *dhcp_anycast_addr,
const char *last_ip_address,
GBytes *vendor_class_identifier,
const char *const *reject_servers,
GError **error)
{
NMDhcpManagerPrivate *priv;
@ -459,6 +462,7 @@ nm_dhcp_manager_start_ip4 (NMDhcpManager *self,
last_ip_address,
0,
vendor_class_identifier,
reject_servers,
error);
}
@ -523,6 +527,7 @@ nm_dhcp_manager_start_ip6 (NMDhcpManager *self,
NULL,
needed_prefixes,
NULL,
NULL,
error);
}

1
src/dhcp/nm-dhcp-manager.h
View file

@ -49,6 +49,7 @@ NMDhcpClient * nm_dhcp_manager_start_ip4 (NMDhcpManager *manager,
const char *dhcp_anycast_addr,
const char *last_ip_address,
GBytes *vendor_class_identifier,
const char *const *reject_servers,
GError **error);
NMDhcpClient * nm_dhcp_manager_start_ip6 (NMDhcpManager *manager,

25
src/dhcp/nm-dhcp-nettools.c
View file

@ -1067,21 +1067,36 @@ bound4_handle (NMDhcpNettools *self, NDhcp4ClientLease *lease, gboolean extended
options);
}
static gboolean
static void
dhcp4_event_handle (NMDhcpNettools *self,
NDhcp4ClientEvent *event)
{
NMDhcpNettoolsPrivate *priv = NM_DHCP_NETTOOLS_GET_PRIVATE (self);
struct in_addr server_id;
char addr_str[INET_ADDRSTRLEN];
int r;
_LOGT ("client event %d", event->event);
switch (event->event) {
case N_DHCP4_CLIENT_EVENT_OFFER:
/* always accept the first lease */
r = n_dhcp4_client_lease_select (event->offer.lease);
if (r)
r = n_dhcp4_client_lease_get_server_identifier (event->offer.lease, &server_id);
if (r) {
_LOGW ("selecting lease failed: %d", r);
return;
}
if (nm_dhcp_client_server_id_is_rejected (NM_DHCP_CLIENT (self), &server_id)) {
_LOGD ("server-id %s is in the reject-list, ignoring",
nm_utils_inet_ntop (AF_INET, &server_id, addr_str));
return;
}
r = n_dhcp4_client_lease_select (event->offer.lease);
if (r) {
_LOGW ("selecting lease failed: %d", r);
return;
}
break;
case N_DHCP4_CLIENT_EVENT_RETRACTED:
case N_DHCP4_CLIENT_EVENT_EXPIRED:
@ -1116,8 +1131,6 @@ dhcp4_event_handle (NMDhcpNettools *self,
_LOGW ("unhandled DHCP event %d", event->event);
break;
}
return TRUE;
}
static gboolean

15
src/dhcp/nm-dhcp-systemd.c
View file

@ -524,6 +524,10 @@ dhcp_event_cb (sd_dhcp_client *client, int event, gpointer user_data)
{
NMDhcpSystemd *self = NM_DHCP_SYSTEMD (user_data);
NMDhcpSystemdPrivate *priv = NM_DHCP_SYSTEMD_GET_PRIVATE (self);
char addr_str[INET_ADDRSTRLEN];
sd_dhcp_lease *lease;
struct in_addr addr;
int r;
nm_assert (priv->client4 == client);
@ -544,6 +548,17 @@ dhcp_event_cb (sd_dhcp_client *client, int event, gpointer user_data)
bound4_handle (self, FALSE);
break;
case SD_DHCP_CLIENT_EVENT_SELECTING:
r = sd_dhcp_client_get_lease (priv->client4, &lease);
if (r < 0)
return r;
r = sd_dhcp_lease_get_server_identifier (lease, &addr);
if (r < 0)
return r;
if (nm_dhcp_client_server_id_is_rejected (NM_DHCP_CLIENT (user_data), &addr)) {
_LOGD ("server-id %s is in the reject-list, ignoring",
nm_utils_inet_ntop (AF_INET, &addr, addr_str));
return -ENOMSG;
}
break;
default:
_LOGW ("unhandled DHCP event %d", event);

1
src/dhcp/tests/test-dhcp-dhclient.c
View file

@ -55,6 +55,7 @@ test_config (const char *orig,
use_fqdn,
hostname_flags,
mud_url,
NULL,
"/path/to/dhclient.conf",
orig,
&new_client_id);

1
src/nm-iface-helper.c
View file

@ -539,6 +539,7 @@ main (int argc, char *argv[])
NULL,
global_opt.dhcp4_address,
NULL,
NULL,
&error);
if (!dhcp4_client)
g_error ("failure to start DHCP: %s", error->message);

12
src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-reader.c
View file

@ -1979,6 +1979,18 @@ make_ip4_setting (shvarFile *ifcfg,
}
g_object_set (s_ip4, NM_SETTING_IP_CONFIG_DAD_TIMEOUT, (int) i64, NULL);
nm_clear_g_free (&value);
v = svGetValueStr (ifcfg, "DHCP_REJECT_SERVERS", &value);
if (v) {
gs_free const char **strv = NULL;
strv = nm_utils_escaped_tokens_split (v, NM_ASCII_SPACES);
if (strv) {
for (item = strv; *item; item++)
nm_setting_ip_config_add_dhcp_reject_server (s_ip4, *item);
}
}
return NM_SETTING (g_steal_pointer (&s_ip4));
}

1
src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-utils.c
View file

@ -872,6 +872,7 @@ const NMSIfcfgKeyTypeInfo nms_ifcfg_well_known_keys[] = {
_KEY_TYPE ("DHCP_HOSTNAME", NMS_IFCFG_KEY_TYPE_IS_PLAIN ),
_KEY_TYPE ("DHCP_HOSTNAME_FLAGS", NMS_IFCFG_KEY_TYPE_IS_PLAIN ),
_KEY_TYPE ("DHCP_IAID", NMS_IFCFG_KEY_TYPE_IS_PLAIN ),
_KEY_TYPE ("DHCP_REJECT_SERVERS", NMS_IFCFG_KEY_TYPE_IS_PLAIN ),
_KEY_TYPE ("DHCP_SEND_HOSTNAME", NMS_IFCFG_KEY_TYPE_IS_PLAIN ),
_KEY_TYPE ("DHCP_VENDOR_CLASS_IDENTIFIER", NMS_IFCFG_KEY_TYPE_IS_PLAIN ),
_KEY_TYPE ("DHCPv6_DUID", NMS_IFCFG_KEY_TYPE_IS_PLAIN ),

2
src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-utils.h
View file

@ -33,7 +33,7 @@ typedef struct {
NMSIfcfgKeyTypeFlags key_flags;
} NMSIfcfgKeyTypeInfo;
extern const NMSIfcfgKeyTypeInfo nms_ifcfg_well_known_keys[242];
extern const NMSIfcfgKeyTypeInfo nms_ifcfg_well_known_keys[243];
const NMSIfcfgKeyTypeInfo *nms_ifcfg_well_known_key_find_info (const char *key, gssize *out_idx);

23
src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-writer.c
View file

@ -2529,10 +2529,11 @@ write_ip4_setting (NMConnection *connection,
NMIPRouteTableSyncMode route_table;
int priority;
int timeout;
GString *searches;
nm_auto_free_gstring GString *str = NULL;
const char *method = NULL;
gboolean has_netmask;
NMDhcpHostnameFlags flags;
const char *const *strv;
NM_SET_OUT (out_route_content_svformat, NULL);
NM_SET_OUT (out_route_content, NULL);
@ -2619,14 +2620,12 @@ write_ip4_setting (NMConnection *connection,
num = nm_setting_ip_config_get_num_dns_searches (s_ip4);
if (num > 0) {
searches = g_string_new (NULL);
nm_gstring_prepare (&str);
for (i = 0; i < num; i++) {
if (i > 0)
g_string_append_c (searches, ' ');
g_string_append (searches, nm_setting_ip_config_get_dns_search (s_ip4, i));
nm_gstring_add_space_delimiter (str);
g_string_append (str, nm_setting_ip_config_get_dns_search (s_ip4, i));
}
svSetValueStr (ifcfg, "DOMAIN", searches->str);
g_string_free (searches, TRUE);
svSetValueStr (ifcfg, "DOMAIN", str->str);
}
/* DEFROUTE; remember that it has the opposite meaning from never-default */
@ -2709,6 +2708,16 @@ write_ip4_setting (NMConnection *connection,
write_res_options (ifcfg, s_ip4, "RES_OPTIONS");
strv = nm_setting_ip_config_get_dhcp_reject_servers (s_ip4, &num);
if (num > 0) {
nm_gstring_prepare (&str);
for (i = 0; i < num; i++) {
nm_gstring_add_space_delimiter (str);
nm_utils_escaped_tokens_escape_gstr (strv[i], NM_ASCII_SPACES, str);
}
svSetValueStr (ifcfg, "DHCP_REJECT_SERVERS", str->str);
}
return TRUE;
}