From ba86c208e0aa6ae5409c93fd7367447450aa51e8 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Wed, 5 Mar 2025 17:18:21 +0100 Subject: [PATCH] Revert "core: prevent the activation of unavailable OVS interfaces only" This was a workaround until the real cause of the issue was found. This reverts commit a1c05d2ce6f115c900ef21b69c3ee7e98ef4ddaf. --- src/core/nm-manager.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/core/nm-manager.c b/src/core/nm-manager.c index a861b2fecd..50e7bc6a53 100644 --- a/src/core/nm-manager.c +++ b/src/core/nm-manager.c @@ -4689,16 +4689,10 @@ found_better: if (nm_g_hash_table_contains(exclude_devices, device)) continue; - /* During startup, NM performs a cleanup of the ovsdb to remove previous entries. - * Before the device is suitable for the connection, it must have ovsdb->ready set - * to TRUE. Performing this check in all kind of interfaces is too agressive and leads - * to race conditions, e.g when a non-virtual bond port gets a carrier, preventing the - * device to be a good candidate for the connection. */ - if (nm_device_get_device_type(device) == NM_DEVICE_TYPE_OVS_INTERFACE - && !nm_device_is_available(device, - for_user_request - ? NM_DEVICE_CHECK_DEV_AVAILABLE_FOR_USER_REQUEST - : NM_DEVICE_CHECK_DEV_AVAILABLE_NONE)) + if (!nm_device_is_available(device, + for_user_request + ? NM_DEVICE_CHECK_DEV_AVAILABLE_FOR_USER_REQUEST + : NM_DEVICE_CHECK_DEV_AVAILABLE_NONE)) continue; /* determine the priority of this device. Currently, this priority is independent