From b98f269b91fc69d1242e6583033cbda7d8550a87 Mon Sep 17 00:00:00 2001 From: Andrew Zaborowski Date: Thu, 18 Oct 2018 17:47:28 +0200 Subject: [PATCH] wifi/iwd: print warning if known network exists in interface-added Something is possibly wrong with the DBus signal handling if a newly added KnownNetwork interface already has an entry in priv->known_networks, but since we handle this case add a warning and update the GDBusProxy pointer for that existing entry. --- src/devices/wifi/nm-iwd-manager.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/devices/wifi/nm-iwd-manager.c b/src/devices/wifi/nm-iwd-manager.c index 24cb8a63ba..1ba8587299 100644 --- a/src/devices/wifi/nm-iwd-manager.c +++ b/src/devices/wifi/nm-iwd-manager.c @@ -544,9 +544,12 @@ interface_added (GDBusObjectManager *object_manager, GDBusObject *object, id = known_network_id_new (name, security); data = g_hash_table_lookup (priv->known_networks, id); - if (data) + if (data) { + _LOGW ("DBus error: KnownNetwork already exists ('%s', %s)", + name, type_str); g_free (id); - else { + nm_g_object_ref_set (&data->known_network, proxy); + } else { data = g_slice_new0 (KnownNetworkData); data->known_network = g_object_ref (proxy); g_hash_table_insert (priv->known_networks, id, data);