From b6d2ae429fc90759905e28a42b9b194e326be737 Mon Sep 17 00:00:00 2001 From: Dan Williams Date: Tue, 16 Apr 2013 15:02:17 -0500 Subject: [PATCH] api: clarify expected agent behavior for GetSecrets and saving secrets Agents are expected to save any new/updated secrets returned to NetworkManager from a GetSecrets call, as it would be silly to return those same secrets right back to the agent via SaveSecrets when the agent is perfectly capable of saving the secrets itself without round-tripping to NetworkManager and back. --- introspection/nm-secret-agent.xml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/introspection/nm-secret-agent.xml b/introspection/nm-secret-agent.xml index e3635b5b4b..48dde703c5 100644 --- a/introspection/nm-secret-agent.xml +++ b/introspection/nm-secret-agent.xml @@ -17,7 +17,11 @@ Retrieve and return stored secrets, if any, or request new - secrets from the agent's user. + secrets from the agent's user. If user interaction is allowed + and the user enters new secrets, the agent is expected to save + the new secrets to persistent storage (if the secret's flags + include AGENT_OWNED) as NetworkManager will not send these + secrets back to the same agent via a SaveSecrets() call.