From b00c6749d7d64fae25d71b46561ed2591b3adbeb Mon Sep 17 00:00:00 2001 From: Conn O'Griofa Date: Sun, 11 May 2025 23:21:30 +0100 Subject: [PATCH] core: fix WPA2 fallback for WPA3 transition APs When connecting to an AP configured for WPA3 transition mode, the connection will fail if PMF is disabled on the client due to SAE and FT-SAE being unconditionally added to the key_mgmt variable's parameters. By removing the "!is_ap ||" check, SAE and FT-SAE will no longer be selected when PMF is disabled, allowing clients to connect via WPA2/PSK mode as per the original intent of a0988868ba7b4390790cab43cca5103f80a6a300. Signed-off-by: Conn O'Griofa --- src/core/supplicant/nm-supplicant-config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/supplicant/nm-supplicant-config.c b/src/core/supplicant/nm-supplicant-config.c index 9e06639510..38294e89a3 100644 --- a/src/core/supplicant/nm-supplicant-config.c +++ b/src/core/supplicant/nm-supplicant-config.c @@ -1012,7 +1012,7 @@ nm_supplicant_config_add_setting_wireless_security(NMSupplicantConfig if (_get_capability(priv, NM_SUPPL_CAP_TYPE_SAE) && _get_capability(priv, NM_SUPPL_CAP_TYPE_PMF) && _get_capability(priv, NM_SUPPL_CAP_TYPE_BIP) - && (!is_ap || pmf != NM_SETTING_WIRELESS_SECURITY_PMF_DISABLE)) { + && (pmf != NM_SETTING_WIRELESS_SECURITY_PMF_DISABLE)) { g_string_append(key_mgmt_conf, " SAE"); if (!is_ap && _get_capability(priv, NM_SUPPL_CAP_TYPE_FT)) g_string_append(key_mgmt_conf, " FT-SAE");