From b3192d2d46fac196c6eb91af0764f7a3b652b697 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 17 Mar 2022 09:52:27 +0100 Subject: [PATCH] device: allow reapply for changed "connection.autoconnect-slaves" property We list the properties that can be reapplied, and reject the reapply operation for any other changes. The idea is that usually reapply of a property requires an explicit implementation (or may not make sense). "connection.autoconnect-slaves" is something that takes effect when activating the master device. It does not matter when the device is already active, thus there is no need to reject the reapply operation. https://bugzilla.redhat.com/show_bug.cgi?id=2065049 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1150 --- src/core/devices/nm-device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/core/devices/nm-device.c b/src/core/devices/nm-device.c index 47daa92e81..e9bf8afcf9 100644 --- a/src/core/devices/nm-device.c +++ b/src/core/devices/nm-device.c @@ -12462,6 +12462,7 @@ can_reapply_change(NMDevice *self, NM_SETTING_CONNECTION_UUID, NM_SETTING_CONNECTION_STABLE_ID, NM_SETTING_CONNECTION_AUTOCONNECT, + NM_SETTING_CONNECTION_AUTOCONNECT_SLAVES, NM_SETTING_CONNECTION_ZONE, NM_SETTING_CONNECTION_METERED, NM_SETTING_CONNECTION_LLDP,