From b0bdaa29c92b9feff700017cce159cdecaa82ce7 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Fri, 22 May 2026 13:48:00 +0200 Subject: [PATCH] dhcp: fix parsing of client id Replace "s[1 + 2]" with "s[i + 2]". Fixes: 8ffa22d10d30 ('dhcp: dhclient: set type 0 for printable client IDs') --- src/core/dhcp/nm-dhcp-dhclient-utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/dhcp/nm-dhcp-dhclient-utils.c b/src/core/dhcp/nm-dhcp-dhclient-utils.c index 286f7aa19f..d90291bd81 100644 --- a/src/core/dhcp/nm-dhcp-dhclient-utils.c +++ b/src/core/dhcp/nm-dhcp-dhclient-utils.c @@ -239,8 +239,8 @@ read_client_id(const char *str) i += 4; continue; } - if (s[i] == '\\' && s[i + 1] >= '0' && s[i + 1] <= '7' && s[1 + 2] >= '0' - && s[i + 2] <= '7' && s[1 + 3] >= '0' && s[i + 3] <= '7') { + if (s[i] == '\\' && s[i + 1] >= '0' && s[i + 1] <= '7' && s[i + 2] >= '0' + && s[i + 2] <= '7' && s[i + 3] >= '0' && s[i + 3] <= '7') { s[j++] = ((s[i + 1] - '0') << 6) + ((s[i + 2] - '0') << 3) + (s[i + 3] - '0'); i += 4; continue;