From af4a41cc4c1cf17bf9d04477cb6c2ebed5daa6ee Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Fri, 2 Aug 2019 08:44:12 +0200 Subject: [PATCH] cli: fix type for loop variable in _get_fcn_vlan_xgress_priority_map() Coverity correctly points out that nm_setting_vlan_get_num_priorities() can return a negative value (-1 on assertion). Handle that by using the right integer type. --- clients/common/nm-meta-setting-desc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/common/nm-meta-setting-desc.c b/clients/common/nm-meta-setting-desc.c index c1a5c2a7fe..5c71868d06 100644 --- a/clients/common/nm-meta-setting-desc.c +++ b/clients/common/nm-meta-setting-desc.c @@ -3755,7 +3755,7 @@ _get_fcn_vlan_xgress_priority_map (ARGS_GET_FCN) NMVlanPriorityMap map_type = _vlan_priority_map_type_from_property_info (property_info); NMSettingVlan *s_vlan = NM_SETTING_VLAN (setting); GString *str = NULL; - guint32 i, num; + gint32 i, num; RETURN_UNSUPPORTED_GET_TYPE ();