From af0eb9e7adf0732921ebe927408a41a36f56f72e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ji=C5=99=C3=AD=20Klime=C5=A1?= Date: Tue, 5 Jun 2012 14:06:48 +0200 Subject: [PATCH] core: don't default to IPv6 temp addr while completing connection (bgo #633233) Enabling NM_SETTING_IP6_CONFIG_PRIVACY_PREFER_TEMP_ADDR in nm_device_complete_connection() made IPv6 temp address enabled for connections created via AddAndActivateConnection() D-Bus call. But it is disabled for other connections. That is not much consistent. So, do not enable IPv6 privacy when completing connections and leave it up to users, who would like to use IPv6 Privacy Extensions, to enable it manually. --- src/nm-device.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/nm-device.c b/src/nm-device.c index ee1091e654..f2bb375700 100644 --- a/src/nm-device.c +++ b/src/nm-device.c @@ -912,14 +912,6 @@ nm_device_complete_connection (NMDevice *self, if (success) success = nm_connection_verify (connection, error); - /* If ip6-privacy is unknown, enable it with temporary address preferred */ - if (success) { - NMSettingIP6Config *s_ip6 = nm_connection_get_setting_ip6_config (connection); - if (s_ip6 && nm_setting_ip6_config_get_ip6_privacy (s_ip6) == NM_SETTING_IP6_CONFIG_PRIVACY_UNKNOWN) - g_object_set (s_ip6, NM_SETTING_IP6_CONFIG_IP6_PRIVACY, - NM_SETTING_IP6_CONFIG_PRIVACY_PREFER_TEMP_ADDR, NULL); - } - return success; }