From ad2d7a73627a7d0d8c41a666be930be073319dbb Mon Sep 17 00:00:00 2001 From: Ratchanan Srirattanamet Date: Sat, 25 Mar 2023 03:20:11 +0700 Subject: [PATCH] wwan/ofono: correct MMS proxy property lookup The property name under `Settings` dict is just `Proxy`, unlike the one outside which is `MessageProxy`. See [1]. [1] https://kernel.googlesource.com/pub/scm/network/ofono/ofono/+/refs/heads/master/doc/connman-api.txt#253 Fixes: a6e81af87f18 ('wwan: add support for using oFono as a modem manager') (cherry picked from commit 264fed47782863ca85841fcf737845decbb9c54c) (cherry picked from commit 7f7fd4244c5480c9c5aca3d52980cb6088e820cd) --- src/core/devices/wwan/nm-modem-ofono.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/core/devices/wwan/nm-modem-ofono.c b/src/core/devices/wwan/nm-modem-ofono.c index fc27c3fd44..877b432048 100644 --- a/src/core/devices/wwan/nm-modem-ofono.c +++ b/src/core/devices/wwan/nm-modem-ofono.c @@ -856,8 +856,8 @@ handle_settings(GVariant *v_dict, gpointer user_data) } } - if (g_variant_lookup(v_dict, "MessageProxy", "&s", &s)) { - _LOGI("MessageProxy: %s", s); + if (g_variant_lookup(v_dict, "Proxy", "&s", &s)) { + _LOGI("(MMS) Proxy: %s", s); if (s && nm_utils_parse_inaddr_bin(AF_INET, s, NULL, &address_network)) { const NMPlatformIP4Route mms_route = { .network = address_network, @@ -871,7 +871,7 @@ handle_settings(GVariant *v_dict, gpointer user_data) nm_l3_config_data_add_route_4(priv->l3cd_4, &mms_route); } else - _LOGW("invalid MessageProxy: %s", s); + _LOGW("invalid (MMS) Proxy: %s", s); } ret = TRUE;