From ac327cb8552aa056f6d8ec60e1ae5c967076490e Mon Sep 17 00:00:00 2001 From: Frederic Martinsons Date: Sat, 29 Jul 2023 06:26:16 +0200 Subject: [PATCH] nmcli: avoid freeing NULL GString and correct error message Fixes #1362 Signed-off-by: Frederic Martinsons --- src/nmcli/connections.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/nmcli/connections.c b/src/nmcli/connections.c index d6413c91f5..c4f70bd1b2 100644 --- a/src/nmcli/connections.c +++ b/src/nmcli/connections.c @@ -2262,7 +2262,7 @@ get_connection(NmCli *nmc, NMCLI_ERROR, NMC_RESULT_ERROR_USER_INPUT, _("%s argument is missing"), - selector); + (*argv)[0]); return NULL; } } else { @@ -9369,8 +9369,10 @@ do_connection_delete(const NMCCommand *cmd, NmCli *nmc, int argc, const char *co g_clear_error(&error); if (nmc->return_value != NMC_RESULT_ERROR_NOT_FOUND) { - g_string_free(invalid_cons, TRUE); - invalid_cons = NULL; + if (invalid_cons) { + g_string_free(invalid_cons, TRUE); + invalid_cons = NULL; + } goto finish; }