fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-05 04:08:01 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

shared/strbuf: only clear the bytes that we actually wrote to

Browse source 
The allocated buffes are not known to be written. It is unnecessary to
clear them.

If the user writes sensitive data to those locations, without using
the NMStrBuf API, then it is up to the user to bzero the memory
accordingly.
This commit is contained in:
Thomas Haller 2020-04-06 10:41:36 +02:00
parent d1c2572e11
commit abacc1e919
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
shared/nm-glib-aux/nm-str-buf.h
View file

@ -194,7 +194,7 @@ nm_str_buf_destroy (NMStrBuf *strbuf)
return;
_nm_str_buf_assert (strbuf);
if (strbuf->_do_bzero_mem)
nm_explicit_bzero (strbuf->_str, strbuf->_allocated);
nm_explicit_bzero (strbuf->_str, strbuf->_len);
g_free (strbuf->_str);
/* the buffer is in invalid state afterwards, however, we clear it