From aa545d5b5849c1ba546242a91ebb37e566a5e0f5 Mon Sep 17 00:00:00 2001
From: Thomas Haller <thaller@redhat.com>
Date: Mon, 9 Dec 2019 09:48:02 +0100
Subject: [PATCH] settings: fix use after free in keyfile's load_connections()

Fixes: d35d3c468a30 ('settings: rework tracking settings connections and settings plugins')
(cherry picked from commit eb642fecdf4f57d4e8673065063cf429e986014a)
(cherry picked from commit 6d37f690ad3b908194e71a83a3362a31e36b2d34)
---
 src/settings/plugins/keyfile/nms-keyfile-plugin.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/settings/plugins/keyfile/nms-keyfile-plugin.c b/src/settings/plugins/keyfile/nms-keyfile-plugin.c
index fbe70ef4d2..e7a1450ae1 100644
--- a/src/settings/plugins/keyfile/nms-keyfile-plugin.c
+++ b/src/settings/plugins/keyfile/nms-keyfile-plugin.c
@@ -369,7 +369,7 @@ _load_file (NMSKeyfilePlugin *self,
 	                              &local);
 	if (!connection) {
 		if (error)
-			g_propagate_error (error, local);
+			g_propagate_error (error, g_steal_pointer (&local));
 		else
 			_LOGW ("load: \"%s\": failed to load connection: %s", full_filename, local->message);
 		return NULL;