From a9c4c1d84ea31fc48293ca0ca62cbe2e8fd997e2 Mon Sep 17 00:00:00 2001 From: Jan Vaclav Date: Mon, 11 Mar 2024 12:22:23 +0100 Subject: [PATCH] libnm/wired: fix mac comparison in _remove_mac_blacklist_item_by_value The comparison checking for MAC address equality had previously been flipped around. Fixes: b084ad7f2b0d ('libnm-core: canonicalize hardware addresses in settings') --- src/libnm-core-impl/nm-setting-wired.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libnm-core-impl/nm-setting-wired.c b/src/libnm-core-impl/nm-setting-wired.c index e09fd70d94..70e2352eef 100644 --- a/src/libnm-core-impl/nm-setting-wired.c +++ b/src/libnm-core-impl/nm-setting-wired.c @@ -415,7 +415,7 @@ nm_setting_wired_remove_mac_blacklist_item_by_value(NMSettingWired *setting, con priv = NM_SETTING_WIRED_GET_PRIVATE(setting); for (i = 0; i < priv->mac_address_blacklist->len; i++) { candidate = nm_g_array_index(priv->mac_address_blacklist, char *, i); - if (!nm_utils_hwaddr_matches(mac, -1, candidate, -1)) { + if (nm_utils_hwaddr_matches(mac, -1, candidate, -1)) { g_array_remove_index(priv->mac_address_blacklist, i); _notify(setting, PROP_MAC_ADDRESS_BLACKLIST); return TRUE;