From a7825e7c16e6f35fb6f4e118b1dd5c2f9884b855 Mon Sep 17 00:00:00 2001 From: Rahul Rajesh Date: Fri, 29 May 2026 13:57:40 -0400 Subject: [PATCH] spec: fallback for version variables In certain environments (Packit for example), shell expansions are disabled for safety reasons. Hence, a fallback is necessary. --- contrib/fedora/rpm/NetworkManager.spec | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/contrib/fedora/rpm/NetworkManager.spec b/contrib/fedora/rpm/NetworkManager.spec index ba12235ddf..3d23836554 100644 --- a/contrib/fedora/rpm/NetworkManager.spec +++ b/contrib/fedora/rpm/NetworkManager.spec @@ -21,8 +21,18 @@ Release: __RELEASE_VERSION__%{?dist} %global wpa_supplicant_version 1:1.1 %global ppp_version %(pkg-config --modversion pppd 2>/dev/null || sed -n 's/^#define\\s*VERSION\\s*"\\([^\\s]*\\)"$/\\1/p' %{_includedir}/pppd/patchlevel.h 2>/dev/null | grep . || echo bad) + +# Certain environments (e.g Packit) disable shell expansion, so we need a fallback +%if "%{?ppp_version}" == "" +%global ppp_version 2.5.2 +%endif + %global glib2_version %(pkg-config --modversion glib-2.0 2>/dev/null || echo bad) +%if "%{?glib2_version}" == "" +%global glib2_version 2.80.0 +%endif + %global bcond_default_debug __BCOND_DEFAULT_DEBUG__ %global bcond_default_lto __BCOND_DEFAULT_LTO__ %global bcond_default_test __BCOND_DEFAULT_TEST__