From a30b2fcd849ef01475e588c0ac4bc3da814cdd59 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20=C5=A0imerda?= Date: Wed, 17 Jan 2018 17:39:24 +0100 Subject: [PATCH] libnm: fix empty statements that were supposed to return NULL Discovered thanks to `-Wunused-value` when building on openSUSE Leap 42.3. (cherry picked from commit c4f655579c0d6bdb4b61a80c49071e81fd035089) --- libnm/nm-client.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libnm/nm-client.c b/libnm/nm-client.c index 8f9c50e9f7..c5a6f1cf56 100644 --- a/libnm/nm-client.c +++ b/libnm/nm-client.c @@ -1408,7 +1408,7 @@ nm_client_get_connection_by_id (NMClient *client, const char *id) g_return_val_if_fail (id != NULL, NULL); if (!nm_client_get_nm_running (client)) - NULL; + return NULL; return nm_remote_settings_get_connection_by_id (NM_CLIENT_GET_PRIVATE (client)->settings, id); } @@ -1433,7 +1433,7 @@ nm_client_get_connection_by_path (NMClient *client, const char *path) g_return_val_if_fail (path != NULL, NULL); if (!nm_client_get_nm_running (client)) - NULL; + return NULL; return nm_remote_settings_get_connection_by_path (NM_CLIENT_GET_PRIVATE (client)->settings, path); } @@ -1458,7 +1458,7 @@ nm_client_get_connection_by_uuid (NMClient *client, const char *uuid) g_return_val_if_fail (uuid != NULL, NULL); if (!nm_client_get_nm_running (client)) - NULL; + return NULL; return nm_remote_settings_get_connection_by_uuid (NM_CLIENT_GET_PRIVATE (client)->settings, uuid); }