diff --git a/ChangeLog b/ChangeLog index ebc4a7050f..5d37f9ae4e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2007-10-03 Dan Williams + + * src/nm-device-802-3-ethernet.c + - (real_get_best_connection): don't create automatic connections + internally; clients should provide a setting that applies to + the device with 'autoconnect: True'. Problem was that these + internally auto-created connections don't have a proxy or service + name becuase they weren't created by a settings daemon, and therefore + clients have no idea what to do with them. + 2007-10-03 Dan Williams * src/nm-device-802-11-wireless.c diff --git a/src/nm-device-802-3-ethernet.c b/src/nm-device-802-3-ethernet.c index 0f7dd6ca93..0123390dca 100644 --- a/src/nm-device-802-3-ethernet.c +++ b/src/nm-device-802-3-ethernet.c @@ -386,26 +386,6 @@ real_get_best_connection (NMDevice *dev, memset (&find_info, 0, sizeof (BestConnectionInfo)); find_info.self = self; g_slist_foreach (connections, find_best_connection, &find_info); - - /* Wired devices autoconnect with DHCP by default if they have a link */ - link_active = nm_device_has_active_link (dev); - if (!find_info.found && link_active) { - NMConnection *connection; - NMSetting *setting; - NMSettingConnection *scon; - - connection = nm_connection_new (); - setting = nm_setting_wired_new (); - nm_connection_add_setting (connection, setting); - - scon = (NMSettingConnection *) nm_setting_connection_new (); - scon->name = g_strdup ("Auto"); - scon->type = g_strdup (setting->name); - nm_connection_add_setting (connection, (NMSetting *) scon); - - find_info.found = connection; - } - return find_info.found; }