From a05dbeb31fca7f2f804583112fd432148c3f737e Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 30 Apr 2020 11:44:06 +0200 Subject: [PATCH] bus-manager/dhcp: don't log pointer values directly Direct pointer values can be used to circumvent ASLR. Obfuscate the pointer values. --- src/nm-dbus-manager.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/nm-dbus-manager.c b/src/nm-dbus-manager.c index 239e06e11a..9849656ddd 100644 --- a/src/nm-dbus-manager.c +++ b/src/nm-dbus-manager.c @@ -247,7 +247,9 @@ private_server_closed_connection (GDBusConnection *conn, CloseConnectionInfo *info; /* Clean up after the connection */ - _LOGD ("(%s) closed connection %p on private socket", s->tag, conn); + _LOGD ("(%s) closed connection "NM_HASH_OBFUSCATE_PTR_FMT" on private socket", + s->tag, + NM_HASH_OBFUSCATE_PTR (conn)); info = g_slice_new0 (CloseConnectionInfo); info->connection = conn; @@ -285,7 +287,9 @@ private_server_new_connection (GDBusServer *server, obj_mgr_data->fake_sender = sender; c_list_link_tail (&s->object_mgr_lst_head, &obj_mgr_data->object_mgr_lst); - _LOGD ("(%s) accepted connection %p on private socket", s->tag, conn); + _LOGD ("(%s) accepted connection "NM_HASH_OBFUSCATE_PTR_FMT" on private socket", + s->tag, + NM_HASH_OBFUSCATE_PTR (conn)); /* Emit this for the manager. *