From 9f5b80d21510c516ec658e09058908c9759142ac Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 12 Oct 2016 10:42:23 +0200 Subject: [PATCH] build: don't guard check-local with "if ENABLE_TESTS" We should enable tests by default, probably we even should drop the configure flags to enable tests and just always build them. Anyway, at this point there is no use in guarding check-local with a check for ENABLE_TESTS. A user who does't want to run the tests, should just not call `make check`. --- libnm-glib/Makefile.am | 5 ----- libnm-util/Makefile.am | 5 ----- src/devices/adsl/Makefile.am | 5 ----- src/devices/bluetooth/Makefile.am | 5 ----- src/devices/team/Makefile.am | 4 ---- src/devices/wifi/Makefile.am | 5 ----- src/devices/wwan/Makefile.am | 5 ----- 7 files changed, 34 deletions(-) diff --git a/libnm-glib/Makefile.am b/libnm-glib/Makefile.am index 6cb3e4b826..71fb7341ad 100644 --- a/libnm-glib/Makefile.am +++ b/libnm-glib/Makefile.am @@ -222,10 +222,5 @@ typelib_DATA = $(INTROSPECTION_GIRS:.gir=.typelib) CLEANFILES += $(gir_DATA) $(typelib_DATA) endif -if ENABLE_TESTS - check-local: $(top_srcdir)/tools/check-exports.sh $(builddir)/.libs/libnm-glib.so $(SYMBOL_VIS_FILE) - -endif - diff --git a/libnm-util/Makefile.am b/libnm-util/Makefile.am index 466e475f23..2991aa93d0 100644 --- a/libnm-util/Makefile.am +++ b/libnm-util/Makefile.am @@ -196,10 +196,5 @@ CLEANFILES = $(gir_DATA) $(typelib_DATA) endif -if ENABLE_TESTS - check-local: $(top_srcdir)/tools/check-exports.sh $(builddir)/.libs/libnm-util.so $(SYMBOL_VIS_FILE) - -endif - diff --git a/src/devices/adsl/Makefile.am b/src/devices/adsl/Makefile.am index 1dbd5a3b4f..bf7f974275 100644 --- a/src/devices/adsl/Makefile.am +++ b/src/devices/adsl/Makefile.am @@ -37,11 +37,6 @@ libnm_device_plugin_adsl_la_LIBADD = \ EXTRA_DIST = $(SYMBOL_VIS_FILE) -if ENABLE_TESTS - check-local: $(top_srcdir)/tools/check-exports.sh $(builddir)/.libs/libnm-device-plugin-adsl.so $(SYMBOL_VIS_FILE) $(call check_so_symbols,$(builddir)/.libs/libnm-device-plugin-adsl.so) - -endif - diff --git a/src/devices/bluetooth/Makefile.am b/src/devices/bluetooth/Makefile.am index 951807aa47..d1a833a3c5 100644 --- a/src/devices/bluetooth/Makefile.am +++ b/src/devices/bluetooth/Makefile.am @@ -73,11 +73,6 @@ endif CLEANFILES = $(BUILT_SOURCES) EXTRA_DIST = $(SYMBOL_VIS_FILE) -if ENABLE_TESTS - check-local: $(top_srcdir)/tools/check-exports.sh $(builddir)/.libs/libnm-device-plugin-bluetooth.so $(SYMBOL_VIS_FILE) $(call check_so_symbols,$(builddir)/.libs/libnm-device-plugin-bluetooth.so) - -endif - diff --git a/src/devices/team/Makefile.am b/src/devices/team/Makefile.am index da9d5b2e7c..350cf0c7c4 100644 --- a/src/devices/team/Makefile.am +++ b/src/devices/team/Makefile.am @@ -47,10 +47,6 @@ endif EXTRA_DIST = $(SYMBOL_VIS_FILE) -if ENABLE_TESTS - check-local: $(top_srcdir)/tools/check-exports.sh $(builddir)/.libs/libnm-device-plugin-team.so $(SYMBOL_VIS_FILE) $(call check_so_symbols,$(builddir)/.libs/libnm-device-plugin-team.so) - -endif diff --git a/src/devices/wifi/Makefile.am b/src/devices/wifi/Makefile.am index c0d303a074..3042b19794 100644 --- a/src/devices/wifi/Makefile.am +++ b/src/devices/wifi/Makefile.am @@ -50,11 +50,6 @@ libnm_device_plugin_wifi_la_LIBADD = \ EXTRA_DIST = $(SYMBOL_VIS_FILE) -if ENABLE_TESTS - check-local: $(top_srcdir)/tools/check-exports.sh $(builddir)/.libs/libnm-device-plugin-wifi.so $(SYMBOL_VIS_FILE) $(call check_so_symbols,$(builddir)/.libs/libnm-device-plugin-wifi.so) - -endif - diff --git a/src/devices/wwan/Makefile.am b/src/devices/wwan/Makefile.am index 7f7e6e8b41..a118a5545c 100644 --- a/src/devices/wwan/Makefile.am +++ b/src/devices/wwan/Makefile.am @@ -85,14 +85,9 @@ libnm_device_plugin_wwan_la_LIBADD = \ CLEANFILES = $(BUILT_SOURCES) EXTRA_DIST = $(SYMBOL_VIS_FILE) $(WWAN_SYMBOL_VIS_FILE) -if ENABLE_TESTS - check-local: $(top_srcdir)/tools/check-exports.sh $(builddir)/.libs/libnm-device-plugin-wwan.so $(SYMBOL_VIS_FILE) $(call check_so_symbols,$(builddir)/.libs/libnm-device-plugin-wwan.so) - $(top_srcdir)/tools/check-exports.sh $(builddir)/.libs/libnm-wwan.so $(WWAN_SYMBOL_VIS_FILE) $(call check_so_symbols,$(builddir)/.libs/libnm-wwan.so) -endif -