fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-05 09:58:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

libnm: fix parsing invalid "pvid" attribute in GVariant in _nm_utils_bridge_vlans_from_dbus()

Browse source 
Complained by Coverity.
This commit is contained in:
Thomas Haller 2019-08-02 11:29:42 +02:00
parent 9e7ca3e091
commit 9f4302e132
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
libnm-core/nm-utils.c
View file

@ -5989,10 +5989,12 @@ _nm_utils_bridge_vlans_from_dbus (NMSetting *setting,
if (vid_start > vid_end)
continue;
g_variant_lookup (vlan_var, "pvid", "b", &pvid);
if (!g_variant_lookup (vlan_var, "pvid", "b", &pvid))
pvid = FALSE;
if (pvid && vid_start != vid_end)
continue;
g_variant_lookup (vlan_var, "untagged", "b", &untagged);
if (!g_variant_lookup (vlan_var, "untagged", "b", &untagged))
untagged = FALSE;
vlan = nm_bridge_vlan_new (vid_start, vid_end);
nm_bridge_vlan_set_untagged (vlan, untagged);