From 9f41fae8647b96ffc2d4fc8b0203a04ea5d98e72 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Sun, 26 Aug 2018 18:21:25 +0200 Subject: [PATCH] wifi: don't use :1 bitfield for gboolean type gboolean is a typedef for "int". While older compilers might treat such bitfields as unsigned ([1]), commonly such a bitfield is signed and can only contain the values 0 and -1. We only want to use numeric 1 for TRUE, hence, creating such bitfields is wrong, or at least error prone. In fact, in this case it's a bug, because later we compare it with a regular gboolean if (priv->scanning != new_scanning) [1] https://lgtm.com/rules/1506024027114/ Fixes: e0f96770188eeaada70a299bd6dab7a50ec34a53 (cherry picked from commit 610ca87016a71a01cf3a7ddf148270290efb7ac3) (cherry picked from commit f326feaba3ddba91416cf02a21de5f040df95636) (cherry picked from commit 7689b9b73bcfe10bae4924fa5b0b5253fb6759e5) --- src/supplicant/nm-supplicant-interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/supplicant/nm-supplicant-interface.c b/src/supplicant/nm-supplicant-interface.c index ab8a0670ee..a462fcae7f 100644 --- a/src/supplicant/nm-supplicant-interface.c +++ b/src/supplicant/nm-supplicant-interface.c @@ -95,7 +95,7 @@ typedef struct { NMSupplicantInterfaceState state; int disconnect_reason; - gboolean scanning:1; + bool scanning:1; bool scan_done_pending:1; bool scan_done_success:1;