From 9e5bb9d62fd960d759e7ec67a84634c8bf6b61b9 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Tue, 17 Dec 2019 15:04:11 +0100 Subject: [PATCH] shared: add missing va_end() to _nm_dbus_error_is() Found by covscan: NetworkManager-1.22.0/shared/nm-glib-aux/nm-dbus-aux.c:361: missing_va_end: va_end was not called for "ap". Fixes: ce36494c0a48 ('shared: add nm_dbus_error_is() helper') (cherry picked from commit 0de4fd6ebc4c3909838087e254a24359e816d0be) --- shared/nm-glib-aux/nm-dbus-aux.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/shared/nm-glib-aux/nm-dbus-aux.c b/shared/nm-glib-aux/nm-dbus-aux.c index 75b282bc14..86061aefdf 100644 --- a/shared/nm-glib-aux/nm-dbus-aux.c +++ b/shared/nm-glib-aux/nm-dbus-aux.c @@ -357,8 +357,10 @@ _nm_dbus_error_is (GError *error, ...) va_start (ap, error); while ((name = va_arg (ap, const char *))) { - if (nm_streq (dbus_error, name)) + if (nm_streq (dbus_error, name)) { + va_end (ap); return TRUE; + } } va_end (ap);