From 9d602529cc5e7442d545979ea6ea79af5046e6fc Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 5 Dec 2019 12:27:13 +0100 Subject: [PATCH] settings/trivial: comment why we create GDBusConnection for ifcfg D-Bus interface There is nothing to fix. Replace the FIXME comment. --- src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-plugin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-plugin.c b/src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-plugin.c index 453307ad85..19c4f51eb4 100644 --- a/src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-plugin.c +++ b/src/settings/plugins/ifcfg-rh/nms-ifcfg-rh-plugin.c @@ -1132,8 +1132,8 @@ _dbus_setup (NMSIfcfgRHPlugin *self) _dbus_clear (self); - /* FIXME: we don't need a separate GDBusConnection. Just reuse the one from - * nm_dbus_manager_get_dbus_connection(). */ + /* We use a separate D-Bus connection so that org.freedesktop.NetworkManager and com.redhat.ifcfgrh1 + * are exported by different connections. */ address = g_dbus_address_get_for_bus_sync (G_BUS_TYPE_SYSTEM, NULL, &error); if (address == NULL) { _LOGW ("dbus: failed getting address for system bus: %s", error->message);