From 9c516a497e9f1b31f419d25a6c105071cb6c6587 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Wed, 20 Jan 2021 18:30:43 +0100 Subject: [PATCH] device: fix assertion failure when resolving hostname nm_device_get_effective_ip_config_method() must called only on a device with an applied connection. Fix assertion failure [1]: nm_device_get_effective_ip_config_method: assertion 'NM_IS_CONNECTION(connection)' failed [1] http://faf.lab.eng.brq.redhat.com/faf/reports/20217/ Fixes: 09c83871144a ('policy: use the hostname setting'): --- src/devices/nm-device.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/devices/nm-device.c b/src/devices/nm-device.c index c6ec4e3bcb..2f4ad2ad24 100644 --- a/src/devices/nm-device.c +++ b/src/devices/nm-device.c @@ -17657,6 +17657,11 @@ nm_device_get_hostname_from_dns_lookup(NMDevice *self, int addr_family, gboolean /* If the device is not supposed to have addresses, * return an immediate empty result.*/ + if (!nm_device_get_applied_connection(self)) { + NM_SET_OUT(out_wait, FALSE); + return NULL; + } + method = nm_device_get_effective_ip_config_method(self, addr_family); if (IS_IPv4) { if (NM_IN_STRSET(method, NM_SETTING_IP4_CONFIG_METHOD_DISABLED)) {