fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-29 05:40:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

ifcfg-rh: fix signature of link_changed() callback

Browse source 
Depending on how arguments are passed to the called function,
this could lead to a crash.

Maybe not on 32 bit machines where the size of the pointer is
the size of an int.

Maybe not on x86_64, where the arguments are passed in registers.

Fixes: b88c309167
(cherry picked from commit 548a5440e9)
(cherry picked from commit cbfdb72db2)
This commit is contained in:
Thomas Haller 2016-10-22 13:46:02 +02:00
parent 55365d8aa1
commit 9bfa908952
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/settings/plugins/ifcfg-rh/nm-ifcfg-connection.c
View file

@ -105,7 +105,7 @@ devtimeout_ready (gpointer user_data)
}
static void
link_changed (NMPlatform *platform, NMPObjectType *obj_type, int ifindex, const NMPlatformLink *link,
link_changed (NMPlatform *platform, NMPObjectType obj_type, int ifindex, const NMPlatformLink *link,
NMPlatformSignalChangeType change_type,
NMConnection *self)
{
@ -116,7 +116,6 @@ link_changed (NMPlatform *platform, NMPObjectType *obj_type, int ifindex, const
if (g_strcmp0 (link->name, ifname) != 0)
return;
/* Shouldn't happen, but... */
if (change_type == NM_PLATFORM_SIGNAL_REMOVED)
return;