fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-20 05:30:34 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

platform: drop checks for failure of nl80211_alloc_msg()

Browse source 
nl80211_alloc_msg() just allocates some memory, using glib's allocators.
Hence it cannot fail, and we don't need to check for that.

Drop the unnecessary %NULL checks.
This commit is contained in:
Thomas Haller 2019-08-01 17:48:48 +02:00
parent 243458836a
commit 990a7bee9d
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/platform/wifi/nm-wifi-utils-nl80211.c
View file

@ -343,8 +343,6 @@ wifi_nl80211_set_wake_on_wlan (NMWifiUtils *data, NMSettingWirelessWakeOnWLan wo
return TRUE;
msg = nl80211_alloc_msg (self, NL80211_CMD_SET_WOWLAN, 0);
if (!msg)
return FALSE;
triggers = nla_nest_start (msg, NL80211_ATTR_WOWLAN_TRIGGERS);
if (!triggers)
@ -636,14 +634,12 @@ nl80211_get_ap_info (NMWifiUtilsNl80211 *self,
return;
msg = nl80211_alloc_msg (self, NL80211_CMD_GET_STATION, 0);
if (msg) {
NLA_PUT (msg, NL80211_ATTR_MAC, ETH_ALEN, bss_info.bssid);
NLA_PUT (msg, NL80211_ATTR_MAC, ETH_ALEN, bss_info.bssid);
nl80211_send_and_recv (self, msg, nl80211_station_handler, sta_info);
if (!sta_info->signal_valid) {
/* Fall back to bss_info signal quality (both are in percent) */
sta_info->signal = bss_info.beacon_signal;
}
nl80211_send_and_recv (self, msg, nl80211_station_handler, sta_info);
if (!sta_info->signal_valid) {
/* Fall back to bss_info signal quality (both are in percent) */
sta_info->signal = bss_info.beacon_signal;
}
return;