fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-29 16:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

wifi: disable mac-address-randomization by default

Browse source 
Enabling it by default can be bad. For example for captive portals.
Effectively revert commit 4f6c91d696
to again disable it by default.

https://bugzilla.gnome.org/show_bug.cgi?id=734081
This commit is contained in:
Thomas Haller 2015-11-18 17:46:25 +01:00
parent f4c7a9d426
commit 98e4194963
2 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
man/NetworkManager.conf.xml.in
View file

@ -612,7 +612,7 @@ ipv6.ip6-privacy=1
</varlistentry>
<varlistentry>
<term><varname>wifi.mac-address-randomization</varname></term>
<listitem><para>If left unspecified, MAC address randomization is used supported.</para></listitem>
<listitem><para>If left unspecified, MAC address randomization is disabled.</para></listitem>
</varlistentry>
</para>
</refsect1>

7
src/supplicant-manager/nm-supplicant-config.c
View file

@ -465,10 +465,9 @@ nm_supplicant_config_add_setting_wireless (NMSupplicantConfig * self,
if (priv->mac_randomization == NM_SETTING_MAC_RANDOMIZATION_DEFAULT) {
priv->mac_randomization = mac_randomization_fallback;
if (priv->mac_randomization == NM_SETTING_MAC_RANDOMIZATION_DEFAULT) {
/* use randomization if supported. */
priv->mac_randomization = (mac_randomization_support == NM_SUPPLICANT_FEATURE_YES)
? NM_SETTING_MAC_RANDOMIZATION_ALWAYS
: NM_SETTING_MAC_RANDOMIZATION_NEVER;
/* Don't use randomization, unless explicitly enabled.
* Randomization can work badly with captive portals. */
priv->mac_randomization = NM_SETTING_MAC_RANDOMIZATION_NEVER;
}
}