From 98bcbd2d2417e965f673220e8ec087a8d3b22ad5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ji=C5=99=C3=AD=20Klime=C5=A1?= Date: Thu, 5 Dec 2013 12:11:36 +0100 Subject: [PATCH] libnm-util: don't touch dhcp-send-hostname when setting dhcp-hostname (rh #1001529) It is better to leave it to user whether he wants to enable sending hostname, because he probably disabled it manually (dhcp-send-hostname is TRUE by default). Also, this would not work for plugins that read and set dhcp-hostname after dhcp-send-hostname. https://bugzilla.redhat.com/show_bug.cgi?id=1001529 --- libnm-util/nm-setting-ip4-config.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libnm-util/nm-setting-ip4-config.c b/libnm-util/nm-setting-ip4-config.c index 5fd1cfd48e..b019a14e5d 100644 --- a/libnm-util/nm-setting-ip4-config.c +++ b/libnm-util/nm-setting-ip4-config.c @@ -908,9 +908,6 @@ set_property (GObject *object, guint prop_id, case PROP_DHCP_HOSTNAME: g_free (priv->dhcp_hostname); priv->dhcp_hostname = g_value_dup_string (value); - /* FIXME: Is this a good idea? */ - if (priv->dhcp_hostname) - priv->dhcp_send_hostname = TRUE; break; case PROP_NEVER_DEFAULT: priv->never_default = g_value_get_boolean (value);