From 986cf3a88733a694a566e4bed6becd6afbe8624e Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Mon, 4 Jan 2016 16:51:19 +0100 Subject: [PATCH] ppp-manager: initialize MTU to zero when not specified When the MTU was not specified in PPP setting, it got the value of a previous option. Fixes: 8f36727ac86ff47b97ffc0c856c1738f8322aa9b --- src/ppp-manager/nm-ppp-manager.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/ppp-manager/nm-ppp-manager.c b/src/ppp-manager/nm-ppp-manager.c index 9cd4a1edd5..ddf4c1e5da 100644 --- a/src/ppp-manager/nm-ppp-manager.c +++ b/src/ppp-manager/nm-ppp-manager.c @@ -433,10 +433,11 @@ set_ip_config_common (NMPPPManager *self, applied_connection = nm_act_request_get_applied_connection (priv->act_req); g_object_set_data (G_OBJECT (applied_connection), PPP_MANAGER_SECRET_TRIES, NULL); - /* Get any custom MTU */ - s_ppp = nm_connection_get_setting_ppp (applied_connection); - if (s_ppp && out_mtu) - *out_mtu = nm_setting_ppp_get_mtu (s_ppp); + if (out_mtu) { + /* Get any custom MTU */ + s_ppp = nm_connection_get_setting_ppp (applied_connection); + *out_mtu = s_ppp ? nm_setting_ppp_get_mtu (s_ppp) : 0; + } monitor_stats (self); return TRUE;