From 96ae8b794f4b7c54185a3a4409d2ee4a888021c4 Mon Sep 17 00:00:00 2001 From: "Sicelo A. Mhlongo" Date: Wed, 13 Sep 2023 10:12:35 +0200 Subject: [PATCH] wwan/ofono: handle missing default gateway It is normal for the operator to not provide a default gateway address, in which case it must be set to 0.0.0.0, as can be seen in upstream ofono test scripts [1]. [1] https://git.kernel.org/pub/scm/network/ofono/ofono.git/commit/test/process-context-settings?id=945a621a2ddfc01b8bdd8936044cb7d2604e8608 Fixes: a6e81af87f18 ('wwan: add support for using oFono as a modem manager') --- src/core/devices/wwan/nm-modem-ofono.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/core/devices/wwan/nm-modem-ofono.c b/src/core/devices/wwan/nm-modem-ofono.c index de105bbdd3..3e0bbd486e 100644 --- a/src/core/devices/wwan/nm-modem-ofono.c +++ b/src/core/devices/wwan/nm-modem-ofono.c @@ -1276,8 +1276,11 @@ handle_settings(NMModemOfono *self, GVariant *v_dict) nm_l3_config_data_add_address_4(priv->l3cd_4, &address); if (!g_variant_lookup(v_dict, "Gateway", "&s", &s) || !s) { - _LOGW("Settings 'Gateway' missing"); - goto out; + /* It is normal for point-to-point connections to not have a gateway IP + * specified. Use 0.0.0.0 in that case. + */ + _LOGD("Settings 'Gateway' missing. Setting it to 0.0.0.0"); + s = "0.0.0.0"; } if (!nm_inet_parse_bin(AF_INET, s, NULL, &gateway_network)) { _LOGW("invalid 'Gateway': %s", s);