From 96a9ce41fbb7d8e0d6d3fe6940809334afb480ff Mon Sep 17 00:00:00 2001 From: Dan Williams Date: Wed, 11 Aug 2010 13:09:33 -0500 Subject: [PATCH] core: ensure dhcp_manager exists before trying to unref it (bgo #626610) If a new device wasn't supported, it gets destroyed by the NMDevice constructor() method. But in the constructor paths the DHCP manager isn't created yet, and so we attempt to unref a non-existent DHCP manager. Usually just a harmless warning, but apparently a crash sometimes. --- src/nm-device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/nm-device.c b/src/nm-device.c index dbbd3266c7..ba004cb7c1 100644 --- a/src/nm-device.c +++ b/src/nm-device.c @@ -3375,7 +3375,8 @@ finalize (GObject *object) NMDevice *self = NM_DEVICE (object); NMDevicePrivate *priv = NM_DEVICE_GET_PRIVATE (self); - g_object_unref (priv->dhcp_manager); + if (priv->dhcp_manager) + g_object_unref (priv->dhcp_manager); g_free (priv->udi); g_free (priv->iface);