From 947f979f267d1e58defaf9fca5ccc33973bcf5e5 Mon Sep 17 00:00:00 2001
From: Thomas Haller <thaller@redhat.com>
Date: Fri, 24 May 2019 09:03:27 +0200
Subject: [PATCH] dispatcher/trivial: add FIXME comment about how to fix
 shutdown of NtworkManager

---
 src/nm-dispatcher.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/nm-dispatcher.c b/src/nm-dispatcher.c
index 9e74bdf5bb..d65f344949 100644
--- a/src/nm-dispatcher.c
+++ b/src/nm-dispatcher.c
@@ -78,6 +78,14 @@ struct NMDispatcherCallId {
 
 /*****************************************************************************/
 
+/* FIXME(shutdown): on shutdown, we should not run dispatcher scripts synchronously.
+ *   Instead, we should of course still run them asynchronously.
+ *
+ *   Also, we should wait for all pending requests to complete before exiting the main-loop
+ *   (with a watchdog). If we hit a timeout, we log a warning and quit (but leave the scripts
+ *   running).
+ *
+ *   Finally, cleanup the global structures. */
 static struct {
 	GDBusConnection *dbus_connection;
 	GHashTable *requests;