From 9436e62471935b0ea02fa8df4b6eed6f1130469c Mon Sep 17 00:00:00 2001 From: Dan Williams Date: Fri, 20 Mar 2009 18:33:58 -0400 Subject: [PATCH] gsm: re-try PIN checking on timeout It seems that some 'hso' devices (Option GT Max 3.6) drop commands on the floor if you issue them too quickly, so retry this one for now. --- src/nm-gsm-device.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/nm-gsm-device.c b/src/nm-gsm-device.c index 4524a46d0b..cc83d1a24a 100644 --- a/src/nm-gsm-device.c +++ b/src/nm-gsm-device.c @@ -717,6 +717,7 @@ check_pin_done (NMSerialDevice *device, break; case 3: case 4: + case -1: /* timeout */ /* Try the pin a few times; sometimes the error is transient */ if (priv->pin_tries++ < 4) { schedule_check_pin_again (NM_GSM_DEVICE (device)); @@ -728,12 +729,6 @@ check_pin_done (NMSerialDevice *device, NM_DEVICE_STATE_REASON_GSM_PIN_CHECK_FAILED); } break; - case -1: - nm_warning ("PIN checking timed out"); - nm_device_state_changed (NM_DEVICE (device), - NM_DEVICE_STATE_FAILED, - NM_DEVICE_STATE_REASON_GSM_PIN_CHECK_FAILED); - break; default: nm_warning ("PIN checking failed"); nm_device_state_changed (NM_DEVICE (device),