From 93131b1df2fc2246fed6004d76d3bbff4fcf60e8 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Mon, 11 Nov 2013 14:43:50 +0100 Subject: [PATCH] cli: fix in matching command line arguments Ensure in matches() that a non-empty cmd is given, otherwise as currently nmcli general - matches to '-h' and is thus treated as nmcli general -h Signed-off-by: Thomas Haller --- cli/src/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cli/src/utils.c b/cli/src/utils.c index da38769798..61fbff8c3c 100644 --- a/cli/src/utils.c +++ b/cli/src/utils.c @@ -38,8 +38,8 @@ int matches (const char *cmd, const char *pattern) { - int len = strlen (cmd); - if (len > strlen (pattern)) + size_t len = strlen (cmd); + if (!len || len > strlen (pattern)) return -1; return memcmp (pattern, cmd, len); }