From 92ebd16cee2a7a306abae7fd3cba3f1366471f14 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Tue, 5 Jun 2018 14:38:58 +0200 Subject: [PATCH] cli: fix array out-of-bounds access on command timeout Fixes: 4b3297271e6f7502631719148d5880489ec56eff https://bugzilla.redhat.com/show_bug.cgi?id=1573839 --- clients/cli/connections.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/cli/connections.c b/clients/cli/connections.c index f8caa10dfe..9b66916fb0 100644 --- a/clients/cli/connections.c +++ b/clients/cli/connections.c @@ -2839,7 +2839,7 @@ connection_cb_info_finish (ConnectionCbInfo *info, gpointer obj) } else { while (info->obj_list->len > 0) { obj = info->obj_list->pdata[info->obj_list->len - 1]; - g_ptr_array_remove_index (info->obj_list, info->obj_list->len); + g_ptr_array_remove_index (info->obj_list, info->obj_list->len - 1); connection_cb_info_obj_list_destroy (info, obj); } }