fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-28 12:10:10 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

ndisc: log DAD failures at info level

Browse source 
A DAD failure is in most cases a symptom of a network
misconfiguration; as such it must be logged in the default
configuration (info level).

While at it, fix other log messages.
This commit is contained in:
Beniamino Galvani 2022-09-06 17:31:08 +02:00
parent addb4e3a0c
commit 922ef4344e
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/core/ndisc/nm-ndisc.c
View file

@ -476,12 +476,12 @@ complete_address(NMNDisc *ndisc, NMNDiscAddress *addr)
priv->config.network_id,
addr->dad_counter++,
&error)) {
_LOGW("complete-address: failed to generate an stable-privacy address: %s",
_LOGW("complete-address: failed to generate a stable-privacy address: %s",
error->message);
g_clear_error(&error);
return FALSE;
}
_LOGD("complete-address: using an stable-privacy address");
_LOGD("complete-address: using a stable-privacy address");
return TRUE;
}
@ -496,7 +496,7 @@ complete_address(NMNDisc *ndisc, NMNDiscAddress *addr)
return TRUE;
}
_LOGW("complete-address: can't generate a new_item EUI-64 address");
_LOGW("complete-address: can't generate a new EUI-64 address");
return FALSE;
}
@ -1241,7 +1241,7 @@ nm_ndisc_dad_failed(NMNDisc *ndisc, GArray *addresses, gboolean emit_changed_sig
if (IN6_ARE_ADDR_EQUAL(&item->address, addr)) {
char sbuf[NM_INET_ADDRSTRLEN];
_LOGD("DAD failed for discovered address %s", nm_inet6_ntop(addr, sbuf));
_LOGI("DAD failed for discovered address %s", nm_inet6_ntop(addr, sbuf));
changed = TRUE;
if (!complete_address(ndisc, item)) {
g_array_remove_index(rdata->addresses, j);