From 903ed7bc598109cbc93b7e77600d7360cbb882a7 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Mon, 30 Oct 2017 10:59:18 +0100 Subject: [PATCH] platform/tests: relax checking for signals in test-link-linux # random seed: R02S4ca8cfc3dace399c0f15b42411e45d2e 1..48 # Start of link tests ok 1 /link/bogus PASS: src/platform/tests/test-link-linux 1 /link/bogus ok 2 /link/loopback PASS: src/platform/tests/test-link-linux 2 /link/loopback nmtst: initialize nmtst_get_rand() with NMTST_SEED_RAND=2697682474 ok 3 /link/internal PASS: src/platform/tests/test-link-linux 3 /link/internal ok 4 /link/external PASS: src/platform/tests/test-link-linux 4 /link/external # Start of software tests ./tools/run-nm-test.sh: line 193: 7589 Trace/breakpoint trap (core dumped) "${NMTST_DBUS_RUN_SESSION[@]}" "$TEST" "$@" NMPlatformSignalAssert: src/platform/tests/test-link.c:298, test_slave(): failure to accept signal 0 times: 'link-changed-changed' ifindex 9 (1 times received) ERROR: src/platform/tests/test-link-linux - too few tests run (expected 48, got 4) ERROR: src/platform/tests/test-link-linux - exited with status 133 (terminated by signal 5?) (cherry picked from commit 1ee6dea02f1084f1e36b46f4b4ace109cd7b348d) --- src/platform/tests/test-link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/platform/tests/test-link.c b/src/platform/tests/test-link.c index ed435567f0..ed34ef1a9d 100644 --- a/src/platform/tests/test-link.c +++ b/src/platform/tests/test-link.c @@ -294,7 +294,7 @@ test_slave (int master, int type, SignalData *master_changed) ensure_no_signal (link_changed); g_assert (nm_platform_link_enslave (NM_PLATFORM_GET, master, ifindex)); accept_signals (link_changed, 0, 2); - ensure_no_signal (master_changed); + accept_signals (master_changed, 0, 2); /* Set slave option */ switch (type) {