From 8edf13d0b4056fbf0048a4827daf87be42c87fcf Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Tue, 6 Jul 2021 09:08:30 +0200 Subject: [PATCH] tools: fix bogus code in "tools/generate-docs-nm-property-infos.py" Coverity warns about this: 2. NetworkManager-1.32.2/tools/generate-docs-nm-property-infos.py:117: identical_branches: The same code is executed regardless of whether "temp.index(subelement) < len(temp) - 1" is true, because the then and else branches are identical. Should one of the branches be modified, or the entire 'if' statement replaced? Fixes: c3504f7e624e ('Rewrite `./tools/generate-docs-nm-property-infos.py` with XML library') (cherry picked from commit dd595c6c1da48814ba790c10dd47088bbdec5589) --- tools/generate-docs-nm-property-infos.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/generate-docs-nm-property-infos.py b/tools/generate-docs-nm-property-infos.py index 238469c66c..fe2053a354 100755 --- a/tools/generate-docs-nm-property-infos.py +++ b/tools/generate-docs-nm-property-infos.py @@ -114,10 +114,7 @@ def pretty_xml(element, newline, level=0): element.text = newline + element.text.strip() + newline temp = list(element) for subelement in temp: - if temp.index(subelement) < (len(temp) - 1): - subelement.tail = newline - else: - subelement.tail = newline + subelement.tail = newline pretty_xml(subelement, newline, level=level + 1)