From 8ecc5e37d3bfb13b23bc01d669325f59e8ac41f8 Mon Sep 17 00:00:00 2001 From: Beniamino Galvani Date: Mon, 17 Oct 2016 15:07:50 +0200 Subject: [PATCH] cli: completion: escape shell special characters "()&!" https://bugzilla.gnome.org/show_bug.cgi?id=772629 (cherry picked from commit 108f04e71eeeb599073eb11ebbdf9b09dabeb6a3) --- clients/cli/nmcli-completion | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/clients/cli/nmcli-completion b/clients/cli/nmcli-completion index ffab7d8b99..5361b09406 100644 --- a/clients/cli/nmcli-completion +++ b/clients/cli/nmcli-completion @@ -25,10 +25,11 @@ _nmcli_list_nl() # [']bla'bla"bla\bla bla --> [']bla'\''bla"bla\bla bla COMPREPLY[$i]="${entry//\'/${escaped_single_quote}}" elif [[ "${cur:0:1}" == '"' ]]; then - # started with double quote, escaping all double quotes and all backslashes + # started with double quote, escaping all double quotes, backslashes and ! # ["]bla'bla"bla\bla bla --> ["]bla'bla\"bla\\bla bla entry="${entry//\\/\\\\}" entry="${entry//\"/\\\"}" + entry="${entry//!/\"\\!\"}" COMPREPLY[$i]="$entry" else # no quotes in front, escaping _everything_ @@ -37,6 +38,10 @@ _nmcli_list_nl() entry="${entry//\'/\'}" entry="${entry//\"/\\\"}" entry="${entry// /\\ }" + entry="${entry//\(/\\(}" + entry="${entry//)/\\)}" + entry="${entry//!/\\!}" + entry="${entry//&/\\&}" COMPREPLY[$i]="$entry" fi (( i++ ))