From 8dd18d91b2c74f43ca2467245f78815bc4df5249 Mon Sep 17 00:00:00 2001 From: Fernando Fernandez Mancera Date: Mon, 6 Mar 2023 11:34:48 +0100 Subject: [PATCH] platform: compare arp_ip_targets_num before arp_ip_target values We must first check whether a->arp_ip_targets_num and b->arp_ip_targets_num are identical. Otherwise, this accesses potentially uninitialized values. Fixes: f900f7bc2c52 ('platform: add netlink support for bond link') --- src/libnm-platform/nm-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libnm-platform/nm-platform.c b/src/libnm-platform/nm-platform.c index 06c1f4a741..42b90a83fa 100644 --- a/src/libnm-platform/nm-platform.c +++ b/src/libnm-platform/nm-platform.c @@ -8062,6 +8062,7 @@ int nm_platform_lnk_bond_cmp(const NMPlatformLnkBond *a, const NMPlatformLnkBond *b) { NM_CMP_SELF(a, b); + NM_CMP_FIELD(a, b, arp_ip_targets_num); NM_CMP_FIELD_MEMCMP_LEN(a, b, arp_ip_target, @@ -8083,7 +8084,6 @@ nm_platform_lnk_bond_cmp(const NMPlatformLnkBond *a, const NMPlatformLnkBond *b) NM_CMP_FIELD_MEMCMP(a, b, ad_actor_system); NM_CMP_FIELD(a, b, ad_select); NM_CMP_FIELD(a, b, all_ports_active); - NM_CMP_FIELD(a, b, arp_ip_targets_num); NM_CMP_FIELD(a, b, fail_over_mac); NM_CMP_FIELD(a, b, lacp_rate); NM_CMP_FIELD(a, b, num_grat_arp);